NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite186f56

committed

Close race condition in slot_creation_error.spec.

Use the pattern from detach-partition-concurrently-3.spec. Perbuildfarm member wrasse.Reviewed by Kyotaro Horiguchi and Andres Freund.Discussion:https://postgr.es/m/20220318072837.GC2739027@rfd.leadboat.com

1 parent4a288a3 commite186f56Copy full SHA for e186f56

File tree

2 files changed

+13

-11

lines changed

contrib/test_decoding
- expected
  - slot_creation_error.out
- specs
  - slot_creation_error.spec

2 files changed

+13

-11

lines changed

`‎contrib/test_decoding/expected/slot_creation_error.out`

Lines changed: 11 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,14 +23,15 @@ step s1_cancel_s2:`
`23`	`23`	`SELECT pg_cancel_backend(pid)`
`24`	`24`	`FROM pg_stat_activity`
`25`	`25`	`WHERE application_name = 'isolation/slot_creation_error/s2';`
`26`		`-`
	`26`	`+ <waiting ...>`
	`27`	`+step s2_init: <... completed>`
	`28`	`+ERROR: canceling statement due to user request`
	`29`	`+step s1_cancel_s2: <... completed>`
`27`	`30`	`pg_cancel_backend`
`28`	`31`	`-----------------`
`29`	`32`	`t`
`30`	`33`	`(1 row)`
`31`	`34`
`32`		`-step s2_init: <... completed>`
`33`		`-ERROR: canceling statement due to user request`
`34`	`35`	`step s1_view_slot:`
`35`	`36`	`SELECT slot_name, slot_type, active FROM pg_replication_slots WHERE slot_name = 'slot_creation_error'`
`36`	`37`
`@@ -90,18 +91,19 @@ step s1_terminate_s2:`
`90`	`91`	`SELECT pg_terminate_backend(pid)`
`91`	`92`	`FROM pg_stat_activity`
`92`	`93`	`WHERE application_name = 'isolation/slot_creation_error/s2';`
`93`		`-`
`94`		`-pg_terminate_backend`
`95`		`---------------------`
`96`		`-t`
`97`		`-(1 row)`
`98`		`-`
	`94`	`+ <waiting ...>`
`99`	`95`	`step s2_init: <... completed>`
`100`	`96`	`FATAL: terminating connection due to administrator command`
`101`	`97`	`server closed the connection unexpectedly`
`102`	`98`	`This probably means the server terminated abnormally`
`103`	`99`	`before or while processing the request.`
`104`	`100`
	`101`	`+step s1_terminate_s2: <... completed>`
	`102`	`+pg_terminate_backend`
	`103`	`+--------------------`
	`104`	`+t`
	`105`	`+(1 row)`
	`106`	`+`
`105`	`107`	`step s1_c: COMMIT;`
`106`	`108`	`step s1_view_slot:`
`107`	`109`	`SELECT slot_name, slot_type, active FROM pg_replication_slots WHERE slot_name = 'slot_creation_error'`

`‎contrib/test_decoding/specs/slot_creation_error.spec`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ step s2_init {`
`35`	`35`	`# The tests first start a transaction with an xid assigned in s1, then create`
`36`	`36`	`# a slot in s2. The slot creation waits for s1's transaction to end. Instead`
`37`	`37`	`# we cancel / terminate s2.`
`38`		`-permutations1_bs1_xids2_inits1_view_slots1_cancel_s2s1_view_slots1_c`
	`38`	`+permutations1_bs1_xids2_inits1_view_slots1_cancel_s2(s2_init)s1_view_slots1_c`
`39`	`39`	`permutations1_bs1_xids2_inits1_cs1_view_slots1_drop_slot# check slot creation still works`
`40`		`-permutations1_bs1_xids2_inits1_terminate_s2s1_cs1_view_slot`
	`40`	`+permutations1_bs1_xids2_inits1_terminate_s2(s2_init)s1_cs1_view_slot`
`41`	`41`	`# can't run tests after this, due to s2's connection failure`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite186f56

File tree

2 files changed

2 files changed

`‎contrib/test_decoding/expected/slot_creation_error.out`

`‎contrib/test_decoding/specs/slot_creation_error.spec`

0 commit comments