Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commite15f32f

Browse files
Set type identifier on BIO
In OpenSSL there are two types of BIO's (I/O abstractions):source/sink and filters. A source/sink BIO is a source and/orsink of data, ie one acting on a socket or a file. A filterBIO takes a stream of input from another BIO and transforms it.In order for BIO_find_type() to be able to traverse the chainof BIO's and correctly find all BIO's of a certain type theyshall have the type bit set accordingly, source/sink BIO's(what PostgreSQL implements) use BIO_TYPE_SOURCE_SINK andfilter BIO's use BIO_TYPE_FILTER. In addition to these, filedescriptor based BIO's should have the descriptor bit set,BIO_TYPE_DESCRIPTOR.The PostgreSQL implementation didn't set the type bits, whichwent unnoticed for a long time as it's only really relevantfor code auditing the OpenSSL installation, or doing similartasks. It is required by the API though, so this fixes it.Backpatch through 9.6 as this has been wrong for a long time.Author: Itamar GafniDiscussion:https://postgr.es/m/SN6PR06MB39665EC10C34BB20956AE4578AF39@SN6PR06MB3966.namprd06.prod.outlook.comBackpatch-through: 9.6
1 parentc9e75c2 commite15f32f

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

‎src/backend/libpq/be-secure-openssl.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -808,6 +808,7 @@ my_BIO_s_socket(void)
808808
my_bio_index=BIO_get_new_index();
809809
if (my_bio_index==-1)
810810
returnNULL;
811+
my_bio_index |= (BIO_TYPE_DESCRIPTOR |BIO_TYPE_SOURCE_SINK);
811812
my_bio_methods=BIO_meth_new(my_bio_index,"PostgreSQL backend socket");
812813
if (!my_bio_methods)
813814
returnNULL;

‎src/interfaces/libpq/fe-secure-openssl.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1642,6 +1642,7 @@ my_BIO_s_socket(void)
16421642
my_bio_index=BIO_get_new_index();
16431643
if (my_bio_index==-1)
16441644
returnNULL;
1645+
my_bio_index |= (BIO_TYPE_DESCRIPTOR |BIO_TYPE_SOURCE_SINK);
16451646
my_bio_methods=BIO_meth_new(my_bio_index,"libpq socket");
16461647
if (!my_bio_methods)
16471648
returnNULL;

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp