NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite148009

committed

Remove ICU tests from default run

These tests require the test database to be in UTF8 encoding. Untilthere is a better solution, take them out of the default test set andtreat them like the existing collate.linux.utf8 test, meaning it has tobe selected manually.

1 parentcd07f73 commite148009Copy full SHA for e148009

File tree

4 files changed

-5

lines changed

doc/src/sgml
- regress.sgml
src/test/regress
- GNUmakefile
- expected
  - collate.icu.utf8.out
- sql
  - collate.icu.utf8.sql

4 files changed

-5

lines changed

`‎doc/src/sgml/regress.sgml`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -264,10 +264,12 @@ make check EXTRA_TESTS=numeric_big`
`264`	`264`	`</screen>`
`265`	`265`	`To run the collation tests:`
`266`	`266`	`<screen>`
`267`		`-make check EXTRA_TESTS=collate.linux.utf8 LANG=en_US.utf8`
	`267`	`+make check EXTRA_TESTS='collate.icu.utf8 collate.linux.utf8' LANG=en_US.utf8`
`268`	`268`	`</screen>`
`269`	`269`	`The <literal>collate.linux.utf8</> test works only on Linux/glibc`
`270`		`- platforms, and only when run in a database that uses UTF-8 encoding.`
	`270`	`+ platforms. The <literal>collate.icu.utf8</literal> test only works when`
	`271`	`+ support for ICU was built. Both tests will only succeed when run in a`
	`272`	`+ database that uses UTF-8 encoding.`
`271`	`273`	`</para>`
`272`	`274`	`</sect2>`
`273`	`275`

`‎src/test/regress/GNUmakefile`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -125,9 +125,6 @@ tablespace-setup:`
`125`	`125`	`##`
`126`	`126`
`127`	`127`	`REGRESS_OPTS = --dlpath=.$(EXTRA_REGRESS_OPTS)`
`128`		`-ifeq ($(with_icu),yes)`
`129`		`-overrideEXTRA_TESTS := collate.icu$(EXTRA_TESTS)`
`130`		`-endif`
`131`	`128`
`132`	`129`	`check: all tablespace-setup`
`133`	`130`	`$(pg_regress_check)$(REGRESS_OPTS) --schedule=$(srcdir)/parallel_schedule$(MAXCONNOPT)$(EXTRA_TESTS)`

`‎src/test/regress/expected/collate.icu.outrenamed to‎src/test/regress/expected/collate.icu.utf8.out`

File renamed without changes.

`‎src/test/regress/sql/collate.icu.sqlrenamed to‎src/test/regress/sql/collate.icu.utf8.sql`

File renamed without changes.

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite148009

File tree

4 files changed

4 files changed

`‎doc/src/sgml/regress.sgml`

`‎src/test/regress/GNUmakefile`

`‎src/test/regress/expected/collate.icu.outrenamed to‎src/test/regress/expected/collate.icu.utf8.out`

`‎src/test/regress/sql/collate.icu.sqlrenamed to‎src/test/regress/sql/collate.icu.utf8.sql`

0 commit comments