NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite135c3d

committed

Fix null pointer dereference in "\c" psql command.

The psql crash happened when no current connection existed. (The secondnew check is optional given today's undocumented NULL argument handlingin PQhost() etc.) Back-patch to 9.0 (all supported versions).

1 parent3b14a17 commite135c3dCopy full SHA for e135c3d

File tree

1 file changed

-2

lines changed

src/bin/psql
- command.c

1 file changed

-2

lines changed

`‎src/bin/psql/command.c‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1753,7 +1753,8 @@ do_connect(char dbname, char user, char host, char port)`
`1753`	`1753`	`* positional syntax.`
`1754`	`1754`	`*/`
`1755`	`1755`	`keep_password=`
`1756`		`-((strcmp(user,PQuser(o_conn))==0)&&`
	`1756`	`+(o_conn&&`
	`1757`	`+ (strcmp(user,PQuser(o_conn))==0)&&`
`1757`	`1758`	`(!host\|\|strcmp(host,PQhost(o_conn))==0)&&`
`1758`	`1759`	`(strcmp(port,PQport(o_conn))==0)&&`
`1759`	`1760`	`!has_connection_string);`
`@@ -1880,7 +1881,8 @@ do_connect(char dbname, char user, char host, char port)`
`1880`	`1881`	`/* Tell the user about the new connection */`
`1881`	`1882`	`if (!pset.quiet)`
`1882`	`1883`	`{`
`1883`		`-if (param_is_newly_set(PQhost(o_conn),PQhost(pset.db))\|\|`
	`1884`	`+if (!o_conn\|\|`
	`1885`	`+param_is_newly_set(PQhost(o_conn),PQhost(pset.db))\|\|`
`1884`	`1886`	`param_is_newly_set(PQport(o_conn),PQport(pset.db)))`
`1885`	`1887`	`{`
`1886`	`1888`	`char*host=PQhost(pset.db);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite135c3d

File tree

1 file changed

1 file changed

`‎src/bin/psql/command.c‎`

0 commit comments