Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commite118555

Browse files
committed
Fix the logic for putting relations into the relcache init file.
Commitf3b5565 was a couple of bricks shyof a load; specifically, it missed putting pg_trigger_tgrelid_tgname_indexinto the relcache init file, because that index is not used by anysyscache. However, we have historically nailed that index into cache forperformance reasons. The upshot was that load_relcache_init_file alwaysdecided that the init file was busted and silently ignored it, resultingin a significant hit to backend startup speed.To fix, reinstantiate RelationIdIsInInitFile() as a wrapper aroundRelationSupportsSysCache(), which can know about additional relationsthat should be in the init file despite being unknown to syscache.c.Also install some guards against future mistakes of this type: makewrite_relcache_init_file Assert that all nailed relations get written tothe init file, and make load_relcache_init_file emit a WARNING if it takesthe "wrong number of nailed relations" exit path. Now that we remove theinit files during postmaster startup, that case should never occur in thefield, even if we are starting a minor-version update that added or removedrels from the nailed set. So the warning shouldn't ever be seen by endusers, but it will show up in the regression tests if somebody breaks thislogic.Back-patch to all supported branches, like the previous commit.
1 parent38c6b19 commite118555

File tree

3 files changed

+53
-11
lines changed

3 files changed

+53
-11
lines changed

‎src/backend/utils/cache/inval.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -508,11 +508,8 @@ RegisterRelcacheInvalidation(Oid dbId, Oid relId)
508508
/*
509509
* If the relation being invalidated is one of those cached in the local
510510
* relcache init file, mark that we need to zap that file at commit.
511-
* (Note: perhaps it would be better if this code were a bit more
512-
* decoupled from the knowledge that the init file contains exactly those
513-
* non-shared rels used in catalog caches.)
514511
*/
515-
if (OidIsValid(dbId)&&RelationSupportsSysCache(relId))
512+
if (OidIsValid(dbId)&&RelationIdIsInInitFile(relId))
516513
transInvalInfo->RelcacheInitFileInval= true;
517514
}
518515

‎src/backend/utils/cache/relcache.c

Lines changed: 51 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4731,21 +4731,32 @@ load_relcache_init_file(bool shared)
47314731
}
47324732

47334733
/*
4734-
* We reached the end of the init file without apparent problem. Did we
4735-
* get the right number of nailed items? (This is a useful crosscheck in
4736-
* case the set of critical rels or indexes changes.)
4734+
* We reached the end of the init file without apparent problem. Did we
4735+
* get the right number of nailed items? This is a useful crosscheck in
4736+
* case the set of critical rels or indexes changes. However, that should
4737+
* not happen in a normally-running system, so let's bleat if it does.
47374738
*/
47384739
if (shared)
47394740
{
47404741
if (nailed_rels!=NUM_CRITICAL_SHARED_RELS||
47414742
nailed_indexes!=NUM_CRITICAL_SHARED_INDEXES)
4743+
{
4744+
elog(WARNING,"found %d nailed shared rels and %d nailed shared indexes in init file, but expected %d and %d respectively",
4745+
nailed_rels,nailed_indexes,
4746+
NUM_CRITICAL_SHARED_RELS,NUM_CRITICAL_SHARED_INDEXES);
47424747
gotoread_failed;
4748+
}
47434749
}
47444750
else
47454751
{
47464752
if (nailed_rels!=NUM_CRITICAL_LOCAL_RELS||
47474753
nailed_indexes!=NUM_CRITICAL_LOCAL_INDEXES)
4754+
{
4755+
elog(WARNING,"found %d nailed rels and %d nailed indexes in init file, but expected %d and %d respectively",
4756+
nailed_rels,nailed_indexes,
4757+
NUM_CRITICAL_LOCAL_RELS,NUM_CRITICAL_LOCAL_INDEXES);
47484758
gotoread_failed;
4759+
}
47494760
}
47504761

47514762
/*
@@ -4863,12 +4874,19 @@ write_relcache_init_file(bool shared)
48634874
/*
48644875
* Ignore if not supposed to be in init file. We can allow any shared
48654876
* relation that's been loaded so far to be in the shared init file,
4866-
* but unshared relations must be used for catalog caches. (Note: if
4867-
* you want to change the criterion for rels to be kept in the init
4868-
* file, see also inval.c.)
4877+
* but unshared relations must be ones that should be in the local
4878+
* file per RelationIdIsInInitFile. (Note: if you want to change the
4879+
* criterion for rels to be kept in the init file, see also inval.c.
4880+
* The reason for filtering here is to be sure that we don't put
4881+
* anything into the local init file for which a relcache inval would
4882+
* not cause invalidation of that init file.)
48694883
*/
4870-
if (!shared&& !RelationSupportsSysCache(RelationGetRelid(rel)))
4884+
if (!shared&& !RelationIdIsInInitFile(RelationGetRelid(rel)))
4885+
{
4886+
/* Nailed rels had better get stored. */
4887+
Assert(!rel->rd_isnailed);
48714888
continue;
4889+
}
48724890

48734891
/* first write the relcache entry proper */
48744892
write_item(rel,sizeof(RelationData),fp);
@@ -4984,6 +5002,32 @@ write_item(const void *data, Size len, FILE *fp)
49845002
elog(FATAL,"could not write init file");
49855003
}
49865004

5005+
/*
5006+
* Determine whether a given relation (identified by OID) is one of the ones
5007+
* we should store in the local relcache init file.
5008+
*
5009+
* We must cache all nailed rels, and for efficiency we should cache every rel
5010+
* that supports a syscache. The former set is almost but not quite a subset
5011+
* of the latter. Currently, we must special-case TriggerRelidNameIndexId,
5012+
* which RelationCacheInitializePhase3 chooses to nail for efficiency reasons,
5013+
* but which does not support any syscache.
5014+
*
5015+
* Note: this function is currently never called for shared rels. If it were,
5016+
* we'd probably also need a special case for DatabaseNameIndexId, which is
5017+
* critical but does not support a syscache.
5018+
*/
5019+
bool
5020+
RelationIdIsInInitFile(OidrelationId)
5021+
{
5022+
if (relationId==TriggerRelidNameIndexId)
5023+
{
5024+
/* If this Assert fails, we don't need this special case anymore. */
5025+
Assert(!RelationSupportsSysCache(relationId));
5026+
return true;
5027+
}
5028+
returnRelationSupportsSysCache(relationId);
5029+
}
5030+
49875031
/*
49885032
* Invalidate (remove) the init file during commit of a transaction that
49895033
* changed one or more of the relation cache entries that are kept in the

‎src/include/utils/relcache.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ extern void AtEOSubXact_RelationCache(bool isCommit, SubTransactionId mySubid,
116116
/*
117117
* Routines to help manage rebuilding of relcache init files
118118
*/
119+
externboolRelationIdIsInInitFile(OidrelationId);
119120
externvoidRelationCacheInitFilePreInvalidate(void);
120121
externvoidRelationCacheInitFilePostInvalidate(void);
121122
externvoidRelationCacheInitFileRemove(void);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp