NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite0e569e

committed

Fix memory leak when initializing DH parameters in backend

When loading DH parameters used for the generation of ephemeral DH keysin the backend, the code has never bothered releasing the memory usedfor the DH information loaded from a file or from libpq's default. Thiscommit makes sure that the information is properly free()'d.Note that as SSL parameters can be reloaded, this can cause an accumulationof memory leaked. As the leak is minor, no backpatch is done.Reported-by: Dmitry UspenskiyDiscussion:https://postgr.es/m/16160-18367e56e9a28264@postgresql.org

1 parent7c85be0 commite0e569eCopy full SHA for e0e569e

File tree

1 file changed

-0

lines changed

src/backend/libpq
- be-secure-openssl.c

1 file changed

-0

lines changed

`‎src/backend/libpq/be-secure-openssl.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1015,8 +1015,11 @@ initialize_dh(SSL_CTX *context, bool isServerStart)`
`1015`	`1015`	`(errcode(ERRCODE_CONFIG_FILE_ERROR),`
`1016`	`1016`	`(errmsg("DH: could not set DH parameters: %s",`
`1017`	`1017`	`SSLerrmessage(ERR_get_error())))));`
	`1018`	`+DH_free(dh);`
`1018`	`1019`	`return false;`
`1019`	`1020`	`}`
	`1021`	`+`
	`1022`	`+DH_free(dh);`
`1020`	`1023`	`return true;`
`1021`	`1024`	`}`
`1022`	`1025`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite0e569e

File tree

1 file changed

1 file changed

`‎src/backend/libpq/be-secure-openssl.c`

0 commit comments