NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite012423

committed

Fix logic bug in dsm_attach().

The previous coding would potentially cause attaching to segment A tofail if segment B was at the same time in the process of going away.Andres Freund, with a comment tweak by me

1 parent4335c95 commite012423Copy full SHA for e012423

File tree

1 file changed

-7

lines changed

src/backend/storage/ipc
- dsm.c

1 file changed

-7

lines changed

`‎src/backend/storage/ipc/dsm.c`

Lines changed: 8 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -566,6 +566,10 @@ dsm_attach(dsm_handle h)`
`566`	`566`	`if (dsm_control->item[i].refcnt==0)`
`567`	`567`	`continue;`
`568`	`568`
	`569`	`+/* If the handle doesn't match, it's not the slot we want. */`
	`570`	`+if (dsm_control->item[i].handle!=seg->handle)`
	`571`	`+continue;`
	`572`	`+`
`569`	`573`	`/*`
`570`	`574`	`* If the reference count is 1, the slot is still in use, but the`
`571`	`575`	`* segment is in the process of going away. Treat that as if we`
`@@ -574,13 +578,10 @@ dsm_attach(dsm_handle h)`
`574`	`578`	`if (dsm_control->item[i].refcnt==1)`
`575`	`579`	`break;`
`576`	`580`
`577`		`-/* Otherwise, if the descriptor matches, we've found a match. */`
`578`		`-if (dsm_control->item[i].handle==seg->handle)`
`579`		`-{`
`580`		`-dsm_control->item[i].refcnt++;`
`581`		`-seg->control_slot=i;`
`582`		`-break;`
`583`		`-}`
	`581`	`+/* Otherwise we've found a match. */`
	`582`	`+dsm_control->item[i].refcnt++;`
	`583`	`+seg->control_slot=i;`
	`584`	`+break;`
`584`	`585`	`}`
`585`	`586`	`LWLockRelease(DynamicSharedMemoryControlLock);`
`586`	`587`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite012423

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/dsm.c`

0 commit comments