NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite00b4f7

committed

Remove redundant JSON parser typedefs

JsonNonTerminal and JsonParserSem were added in commit3311ea8These names of these two enums are not actually used, so there is noneed for typedefs. Instead use plain enums to declare the constants.Noticed by Alvaro Herera.

1 parented52df3 commite00b4f7Copy full SHA for e00b4f7

File tree

2 files changed

-6

lines changed

src
- common
  - jsonapi.c
- tools/pgindent
  - typedefs.list

2 files changed

-6

lines changed

`‎src/common/jsonapi.c`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,16 +50,16 @@ typedef enum/* contexts of JSON parser */`
`50`	`50`	`* tokens, non-terminals, and semantic action markers.`
`51`	`51`	`*/`
`52`	`52`
`53`		`-typedefenum`
	`53`	`+enumJsonNonTerminal`
`54`	`54`	`{`
`55`	`55`	`JSON_NT_JSON=32,`
`56`	`56`	`JSON_NT_ARRAY_ELEMENTS,`
`57`	`57`	`JSON_NT_MORE_ARRAY_ELEMENTS,`
`58`	`58`	`JSON_NT_KEY_PAIRS,`
`59`	`59`	`JSON_NT_MORE_KEY_PAIRS,`
`60`		`-}JsonNonTerminal;`
	`60`	`+};`
`61`	`61`
`62`		`-typedefenum`
	`62`	`+enumJsonParserSem`
`63`	`63`	`{`
`64`	`64`	`JSON_SEM_OSTART=64,`
`65`	`65`	`JSON_SEM_OEND,`
`@@ -72,7 +72,7 @@ typedef enum`
`72`	`72`	`JSON_SEM_AELEM_END,`
`73`	`73`	`JSON_SEM_SCALAR_INIT,`
`74`	`74`	`JSON_SEM_SCALAR_CALL,`
`75`		`-}JsonParserSem;`
	`75`	`+};`
`76`	`76`
`77`	`77`	`/*`
`78`	`78`	`* struct containing the 3 stacks used in non-recursive parsing,`

`‎src/tools/pgindent/typedefs.list`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1312,14 +1312,12 @@ JsonManifestParseIncrementalState`
`1312`	`1312`	`JsonManifestParseState`
`1313`	`1313`	`JsonManifestSemanticState`
`1314`	`1314`	`JsonManifestWALRangeField`
`1315`		`-JsonNonTerminal`
`1316`	`1315`	`JsonObjectAgg`
`1317`	`1316`	`JsonObjectConstructor`
`1318`	`1317`	`JsonOutput`
`1319`	`1318`	`JsonParseExpr`
`1320`	`1319`	`JsonParseContext`
`1321`	`1320`	`JsonParseErrorType`
`1322`		`-JsonParserSem`
`1323`	`1321`	`JsonParserStack`
`1324`	`1322`	`JsonPath`
`1325`	`1323`	`JsonPathBool`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite00b4f7

File tree

2 files changed

2 files changed

`‎src/common/jsonapi.c`

`‎src/tools/pgindent/typedefs.list`

0 commit comments