NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitdffde5b

committed

Fix defects in PrepareForIncrementalBackup.

Swap the arguments to TimestampDifferenceMilliseconds so that we geta positive answer instead of zero.Then use the result of that computation instead of ignoring it.Per reports from Alexander Lakhin.Discussion:http://postgr.es/m/8b686764-7ac1-74c3-70f9-b64685a2535f@gmail.com

1 parent8ce5aef commitdffde5bCopy full SHA for dffde5b

File tree

1 file changed

-2

lines changed

src/backend/backup
- basebackup_incremental.c

1 file changed

-2

lines changed

`‎src/backend/backup/basebackup_incremental.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -436,12 +436,12 @@ PrepareForIncrementalBackup(IncrementalBackupInfo *ib,`
`436`	`436`	`* drifting to something that is not a multiple of ten.`
`437`	`437`	`*/`
`438`	`438`	`timeout_in_ms-=`
`439`		`-TimestampDifferenceMilliseconds(current_time,initial_time) %`
	`439`	`+TimestampDifferenceMilliseconds(initial_time,current_time) %`
`440`	`440`	`timeout_in_ms;`
`441`	`441`
`442`	`442`	`/* Wait for up to 10 seconds. */`
`443`	`443`	`summarized_lsn=WaitForWalSummarization(backup_state->startpoint,`
`444`		`-10000,&pending_lsn);`
	`444`	`+timeout_in_ms,&pending_lsn);`
`445`	`445`
`446`	`446`	`/* If WAL summarization has progressed sufficiently, stop waiting. */`
`447`	`447`	`if (summarized_lsn >=backup_state->startpoint)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdffde5b

File tree

1 file changed

1 file changed

`‎src/backend/backup/basebackup_incremental.c`

0 commit comments