Commitdfdb2f3

committed

test_decoding: Add comments about delaying BEGIN/PREPARE

It is not immediately obvious why we return early in these functions;these comments should make it so.Reviewed-by: Tomas Vondra <tomas.vondra@enterprisedb.com>Discussion:https://postgr.es/m/202202141336.xv35beswc6ec@alvherre.pgsql

1 parent68d8f9b commitdfdb2f3Copy full SHA for dfdb2f3

File tree

+12

-0

lines changed

+12

-0

lines changed

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -322,6 +322,10 @@ pg_decode_begin_txn(LogicalDecodingContext ctx, ReorderBufferTXN txn)`
`322`	`322`	`txndata->xact_wrote_changes= false;`
`323`	`323`	`txn->output_plugin_private=txndata;`
`324`	`324`
	`325`	`+/*`
	`326`	`+ * If asked to skip empty transactions, we'll emit BEGIN at the point where`
	`327`	`+ * the first operation is received for this transaction.`
	`328`	`+ */`
`325`	`329`	`if (data->skip_empty_xacts)`
`326`	`330`	`return;`
`327`	`331`
`@@ -378,6 +382,10 @@ pg_decode_begin_prepare_txn(LogicalDecodingContext ctx, ReorderBufferTXN txn)`
`378`	`382`	`txndata->xact_wrote_changes= false;`
`379`	`383`	`txn->output_plugin_private=txndata;`
`380`	`384`
	`385`	`+/*`
	`386`	`+ * If asked to skip empty transactions, we'll emit BEGIN at the point where`
	`387`	`+ * the first operation is received for this transaction.`
	`388`	`+ */`
`381`	`389`	`if (data->skip_empty_xacts)`
`382`	`390`	`return;`
`383`	`391`
`@@ -392,6 +400,10 @@ pg_decode_prepare_txn(LogicalDecodingContext ctx, ReorderBufferTXN txn,`
`392`	`400`	`TestDecodingData*data=ctx->output_plugin_private;`
`393`	`401`	`TestDecodingTxnData*txndata=txn->output_plugin_private;`
`394`	`402`
	`403`	`+/*`
	`404`	`+ * If asked to skip empty transactions, we'll emit PREPARE at the point`
	`405`	`+ * where the first operation is received for this transaction.`
	`406`	`+ */`
`395`	`407`	`if (data->skip_empty_xacts&& !txndata->xact_wrote_changes)`
`396`	`408`	`return;`
`397`	`409`

Comments

(0)