NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitdf9274a

committed

Add some checkpoint/restartpoint status to ps display

This is done for end-of-recovery and shutdown checkpoints/restartpoints(end-of-recovery restartpoints don't exist) rather than all types ofcheckpoints, in cases where it may not be possible to rely onpg_stat_activity to get a status from the startup or checkpointerprocesses.For example, at the end of a crash recovery, this is useful to know if acheckpoint is running in the startup process, while previously the psdisplay may only show some information about "recovering" something,that can be confusing while a checkpoint runs.Author: Justin PryzbyReviewed-by: Nathan Bossart, Kirk Jamison, Fujii Masao, Michael PaquierDiscussion:https://postgr.es/m/20200818225238.GP17022@telsasoft.com

1 parenta1b8aa1 commitdf9274aCopy full SHA for df9274a

File tree

1 file changed

+45

-0

lines changed

src/backend/access/transam
- xlog.c

1 file changed

+45

-0

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 45 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -8687,6 +8687,39 @@ UpdateCheckPointDistanceEstimate(uint64 nbytes)`
`8687`	`8687`	`(0.90CheckPointDistanceEstimate+0.10 (double)nbytes);`
`8688`	`8688`	`}`
`8689`	`8689`
	`8690`	`+/*`
	`8691`	`+ * Update the ps display for a process running a checkpoint. Note that`
	`8692`	`+ * this routine should not do any allocations so as it can be called`
	`8693`	`+ * from a critical section.`
	`8694`	`+ */`
	`8695`	`+staticvoid`
	`8696`	`+update_checkpoint_display(intflags,boolrestartpoint,boolreset)`
	`8697`	`+{`
	`8698`	`+/*`
	`8699`	`+ * The status is reported only for end-of-recovery and shutdown`
	`8700`	`+ * checkpoints or shutdown restartpoints. Updating the ps display is`
	`8701`	`+ * useful in those situations as it may not be possible to rely on`
	`8702`	`+ * pg_stat_activity to see the status of the checkpointer or the startup`
	`8703`	`+ * process.`
	`8704`	`+ */`
	`8705`	`+if ((flags& (CHECKPOINT_END_OF_RECOVERY \|CHECKPOINT_IS_SHUTDOWN))==0)`
	`8706`	`+return;`
	`8707`	`+`
	`8708`	`+if (reset)`
	`8709`	`+set_ps_display("");`
	`8710`	`+else`
	`8711`	`+{`
	`8712`	`+charactivitymsg[128];`
	`8713`	`+`
	`8714`	`+snprintf(activitymsg,sizeof(activitymsg),"performing %s%s%s",`
	`8715`	`+ (flags&CHECKPOINT_END_OF_RECOVERY) ?"end-of-recovery " :"",`
	`8716`	`+ (flags&CHECKPOINT_IS_SHUTDOWN) ?"shutdown " :"",`
	`8717`	`+restartpoint ?"restartpoint" :"checkpoint");`
	`8718`	`+set_ps_display(activitymsg);`
	`8719`	`+}`
	`8720`	`+}`
	`8721`	`+`
	`8722`	`+`
`8690`	`8723`	`/*`
`8691`	`8724`	`* Perform a checkpoint --- either during shutdown, or on-the-fly`
`8692`	`8725`	`*`
`@@ -8905,6 +8938,9 @@ CreateCheckPoint(int flags)`
`8905`	`8938`	`if (log_checkpoints)`
`8906`	`8939`	`LogCheckpointStart(flags, false);`
`8907`	`8940`
	`8941`	`+/* Update the process title */`
	`8942`	`+update_checkpoint_display(flags, false, false);`
	`8943`	`+`
`8908`	`8944`	`TRACE_POSTGRESQL_CHECKPOINT_START(flags);`
`8909`	`8945`
`8910`	`8946`	`/*`
`@@ -9120,6 +9156,9 @@ CreateCheckPoint(int flags)`
`9120`	`9156`	`/* Real work is done, but log and update stats before releasing lock. */`
`9121`	`9157`	`LogCheckpointEnd(false);`
`9122`	`9158`
	`9159`	`+/* Reset the process title */`
	`9160`	`+update_checkpoint_display(flags, false, true);`
	`9161`	`+`
`9123`	`9162`	`TRACE_POSTGRESQL_CHECKPOINT_DONE(CheckpointStats.ckpt_bufs_written,`
`9124`	`9163`	`NBuffers,`
`9125`	`9164`	`CheckpointStats.ckpt_segs_added,`
`@@ -9374,6 +9413,9 @@ CreateRestartPoint(int flags)`
`9374`	`9413`	`if (log_checkpoints)`
`9375`	`9414`	`LogCheckpointStart(flags, true);`
`9376`	`9415`
	`9416`	`+/* Update the process title */`
	`9417`	`+update_checkpoint_display(flags, true, false);`
	`9418`	`+`
`9377`	`9419`	`CheckPointGuts(lastCheckPoint.redo,flags);`
`9378`	`9420`
`9379`	`9421`	`/*`
`@@ -9492,6 +9534,9 @@ CreateRestartPoint(int flags)`
`9492`	`9534`	`/* Real work is done, but log and update before releasing lock. */`
`9493`	`9535`	`LogCheckpointEnd(true);`
`9494`	`9536`
	`9537`	`+/* Reset the process title */`
	`9538`	`+update_checkpoint_display(flags, true, true);`
	`9539`	`+`
`9495`	`9540`	`xtime=GetLatestXTime();`
`9496`	`9541`	`ereport((log_checkpoints ?LOG :DEBUG2),`
`9497`	`9542`	`(errmsg("recovery restart point at %X/%X",`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdf9274a

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments