NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitdf0f4fe

committed

Add missing padding from MemoryChunk struct

Buildfarm animals skate, grison and mamba are Assert failing on thepointer being given to repalloc not being MAXALIGNED.c6e0fe1 madechanges in that area.All of these animals are 32-bit with a MAXIMUM_ALIGNOF of 8 and aSIZEOF_VOID_P of 4. I suspect that the pointer is not properly aligned dueto the lack of padding in the MemoryChunk struct.Here we add the same type of padding that was previously used inAllocChunkData and GenerationChunk thatc6e0fe1 neglected to add.Discussion:https://postgr.es/m/CAA4eK1%2B1JyW5TiL%3DyV-3Uq1CrfnTyn0Xrk5uArt31Z%3D8rgPhXQ%40mail.gmail.com

1 parentc6a43c2 commitdf0f4feCopy full SHA for df0f4fe

File tree

1 file changed

-0

lines changed

src/include/utils
- memutils_memorychunk.h

1 file changed

-0

lines changed

`‎src/include/utils/memutils_memorychunk.h`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,14 @@ typedef struct MemoryChunk`
`111`	`111`	`{`
`112`	`112`	`#ifdefMEMORY_CONTEXT_CHECKING`
`113`	`113`	`Sizerequested_size;`
	`114`	`+#defineMEMORYCHUNK_RAWSIZE(SIZEOF_SIZE_T + 8)`
	`115`	`+#else`
	`116`	`+#defineMEMORYCHUNK_RAWSIZE8`
	`117`	`+#endif/* MEMORY_CONTEXT_CHECKING */`
	`118`	`+`
	`119`	`+/* ensure proper alignment by adding padding if needed */`
	`120`	`+#if (MEMORYCHUNK_RAWSIZE %MAXIMUM_ALIGNOF)!=0`
	`121`	`+charpadding[MAXIMUM_ALIGNOF-MEMORYCHUNK_RAWSIZE %MAXIMUM_ALIGNOF];`
`114`	`122`	`#endif`
`115`	`123`
`116`	`124`	`/* bitfield for storing details about the chunk */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdf0f4fe

File tree

1 file changed

1 file changed

`‎src/include/utils/memutils_memorychunk.h`

0 commit comments