NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitdec9184

committed

I guess I'd vote for changing the code to be

sys = malloc(strlen(editorName) + strlen(fname) + 10 + 1); if (!sys) return false; sprintf(sys, "exec '%s' '%s'", editorName, fname);(note the added quotes to provide a little protection against spacesand such). Then it's perfectly obvious what the calculation is doing.I don't care about wasting 20-some bytes, but confusing readers of thecode is worth avoiding. regards, tom lane

1 parent538b101 commitdec9184Copy full SHA for dec9184

File tree

2 files changed

-5

lines changed

doc
- TODO
src/bin/psql
- command.c

2 files changed

-5

lines changed

`‎doc/TODO`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`TODO list for PostgreSQL`
`2`	`2`	`========================`
`3`		`-Last updated:Wed Aug 1400:57:54 EDT 2002`
	`3`	`+Last updated:Wed Aug 1401:46:11 EDT 2002`
`4`	`4`
`5`	`5`	`Current maintainer:Bruce Momjian (pgman@candle.pha.pa.us)`
`6`	`6`
`@@ -205,7 +205,8 @@ Commands`
`205`	`205`	`o Add ALTER TABLE tab SET WITHOUT OIDS`
`206`	`206`
`207`	`207`	`* CLUSTER`
`208`		`-o Cluster all tables at once`
	`208`	`+o Cluster all tables at once using pg_index.indisclustered or primary`
	`209`	`+ key`
`209`	`210`	`o Prevent loss of indexes, permissions, inheritance`
`210`	`211`	`o Automatically maintain clustering on a table`
`211`	`212`

`‎src/bin/psql/command.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*`
`4`	`4`	`* Copyright 2000-2002 by PostgreSQL Global Development Group`
`5`	`5`	`*`
`6`		`- * $Header: /cvsroot/pgsql/src/bin/psql/command.c,v 1.77 2002/08/13 21:04:36 momjian Exp $`
	`6`	`+ * $Header: /cvsroot/pgsql/src/bin/psql/command.c,v 1.78 2002/08/14 05:49:22 momjian Exp $`
`7`	`7`	`*/`
`8`	`8`	`#include"postgres_fe.h"`
`9`	`9`	`#include"command.h"`
`@@ -1510,10 +1510,10 @@ editFile(const char *fname)`
`1510`	`1510`	`if (!editorName)`
`1511`	`1511`	`editorName=DEFAULT_EDITOR;`
`1512`	`1512`
`1513`		`-sys=malloc(strlen(editorName)+strlen(fname)+32+1);`
	`1513`	`+sys=malloc(strlen(editorName)+strlen(fname)+10+1);`
`1514`	`1514`	`if (!sys)`
`1515`	`1515`	`return false;`
`1516`		`-sprintf(sys,"exec%s %s",editorName,fname);`
	`1516`	`+sprintf(sys,"exec '%s' '%s'",editorName,fname);`
`1517`	`1517`	`result=system(sys);`
`1518`	`1518`	`if (result==-1)`
`1519`	`1519`	`psql_error("could not start editor %s\n",editorName);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdec9184

File tree

2 files changed

2 files changed

`‎doc/TODO`

`‎src/bin/psql/command.c`

0 commit comments