Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitddbba3a

Browse files
committed
Rename PageData to GenericXLogPageData
In the PostgreSQL C type naming schema, the type PageData should bewhat the pointer of type Page points to. But in this case it'sactually an unrelated type local to generic_xlog.c. Rename that to amore specific name. This makes room to possible add a PageData typewith the mentioned meaning, but this is not done here.Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>Reviewed-by: Michael Paquier <michael@paquier.xyz>Discussion:https://www.postgresql.org/message-id/flat/001d457e-c118-4219-8132-e1846c2ae3c9%40eisentraut.org
1 parent9428c00 commitddbba3a

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

‎src/backend/access/transam/generic_xlog.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ typedef struct
5555
char*image;/* copy of page image for modification, do not
5656
* do it in-place to have aligned memory chunk */
5757
chardelta[MAX_DELTA_SIZE];/* delta between page images */
58-
}PageData;
58+
}GenericXLogPageData;
5959

6060
/*
6161
* State of generic xlog record construction. Must be allocated at an I/O
@@ -66,17 +66,17 @@ struct GenericXLogState
6666
/* Page images (properly aligned, must be first) */
6767
PGIOAlignedBlockimages[MAX_GENERIC_XLOG_PAGES];
6868
/* Info about each page, see above */
69-
PageDatapages[MAX_GENERIC_XLOG_PAGES];
69+
GenericXLogPageDatapages[MAX_GENERIC_XLOG_PAGES];
7070
boolisLogged;
7171
};
7272

73-
staticvoidwriteFragment(PageData*pageData,OffsetNumberoffset,
73+
staticvoidwriteFragment(GenericXLogPageData*pageData,OffsetNumberoffset,
7474
OffsetNumberlength,constchar*data);
75-
staticvoidcomputeRegionDelta(PageData*pageData,
75+
staticvoidcomputeRegionDelta(GenericXLogPageData*pageData,
7676
constchar*curpage,constchar*targetpage,
7777
inttargetStart,inttargetEnd,
7878
intvalidStart,intvalidEnd);
79-
staticvoidcomputeDelta(PageData*pageData,Pagecurpage,Pagetargetpage);
79+
staticvoidcomputeDelta(GenericXLogPageData*pageData,Pagecurpage,Pagetargetpage);
8080
staticvoidapplyPageRedo(Pagepage,constchar*delta,SizedeltaSize);
8181

8282

@@ -87,7 +87,7 @@ static void applyPageRedo(Page page, const char *delta, Size deltaSize);
8787
* actual data (of length length).
8888
*/
8989
staticvoid
90-
writeFragment(PageData*pageData,OffsetNumberoffset,OffsetNumberlength,
90+
writeFragment(GenericXLogPageData*pageData,OffsetNumberoffset,OffsetNumberlength,
9191
constchar*data)
9292
{
9393
char*ptr=pageData->delta+pageData->deltaLen;
@@ -118,7 +118,7 @@ writeFragment(PageData *pageData, OffsetNumber offset, OffsetNumber length,
118118
* about the data-matching loops.
119119
*/
120120
staticvoid
121-
computeRegionDelta(PageData*pageData,
121+
computeRegionDelta(GenericXLogPageData*pageData,
122122
constchar*curpage,constchar*targetpage,
123123
inttargetStart,inttargetEnd,
124124
intvalidStart,intvalidEnd)
@@ -225,7 +225,7 @@ computeRegionDelta(PageData *pageData,
225225
* and store it in pageData's delta field.
226226
*/
227227
staticvoid
228-
computeDelta(PageData*pageData,Pagecurpage,Pagetargetpage)
228+
computeDelta(GenericXLogPageData*pageData,Pagecurpage,Pagetargetpage)
229229
{
230230
inttargetLower= ((PageHeader)targetpage)->pd_lower,
231231
targetUpper= ((PageHeader)targetpage)->pd_upper,
@@ -303,7 +303,7 @@ GenericXLogRegisterBuffer(GenericXLogState *state, Buffer buffer, int flags)
303303
/* Search array for existing entry or first unused slot */
304304
for (block_id=0;block_id<MAX_GENERIC_XLOG_PAGES;block_id++)
305305
{
306-
PageData*page=&state->pages[block_id];
306+
GenericXLogPageData*page=&state->pages[block_id];
307307

308308
if (BufferIsInvalid(page->buffer))
309309
{
@@ -352,7 +352,7 @@ GenericXLogFinish(GenericXLogState *state)
352352
*/
353353
for (i=0;i<MAX_GENERIC_XLOG_PAGES;i++)
354354
{
355-
PageData*pageData=&state->pages[i];
355+
GenericXLogPageData*pageData=&state->pages[i];
356356
Pagepage;
357357
PageHeaderpageHeader;
358358

@@ -401,7 +401,7 @@ GenericXLogFinish(GenericXLogState *state)
401401
/* Set LSN */
402402
for (i=0;i<MAX_GENERIC_XLOG_PAGES;i++)
403403
{
404-
PageData*pageData=&state->pages[i];
404+
GenericXLogPageData*pageData=&state->pages[i];
405405

406406
if (BufferIsInvalid(pageData->buffer))
407407
continue;
@@ -415,7 +415,7 @@ GenericXLogFinish(GenericXLogState *state)
415415
START_CRIT_SECTION();
416416
for (i=0;i<MAX_GENERIC_XLOG_PAGES;i++)
417417
{
418-
PageData*pageData=&state->pages[i];
418+
GenericXLogPageData*pageData=&state->pages[i];
419419

420420
if (BufferIsInvalid(pageData->buffer))
421421
continue;

‎src/tools/pgindent/typedefs.list

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1003,6 +1003,7 @@ GenerationBlock
10031003
GenerationContext
10041004
GenerationPointer
10051005
GenericCosts
1006+
GenericXLogPageData
10061007
GenericXLogState
10071008
GeqoPrivateData
10081009
GetForeignJoinPaths_function
@@ -1975,7 +1976,6 @@ PX_Combo
19751976
PX_HMAC
19761977
PX_MD
19771978
Page
1978-
PageData
19791979
PageGistNSN
19801980
PageHeader
19811981
PageHeaderData

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp