Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitdd5d995

Browse files
committed
Empty search_path in logical replication apply worker and walsender.
This is likeCVE-2018-1058 commit582edc3. Today, a malicious user of apublisher or subscriber database can invoke arbitrary SQL functionsunder an identity running replication, often a superuser. This fix maycause "does not exist" or "no schema has been selected to create in"errors in a replication process. After upgrading, consider watchingserver logs for these errors. Objects accruing schema qualification inthe wake of the earlier commit are unlikely to need further correction.Back-patch to v10, which introduced logical replication.Security:CVE-2020-14349
1 parent670050d commitdd5d995

File tree

3 files changed

+27
-0
lines changed

3 files changed

+27
-0
lines changed

‎src/backend/replication/libpqwalreceiver/libpqwalreceiver.c‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include"pqexpbuffer.h"
2424
#include"access/xlog.h"
2525
#include"catalog/pg_type.h"
26+
#include"common/connect.h"
2627
#include"funcapi.h"
2728
#include"mb/pg_wchar.h"
2829
#include"miscadmin.h"
@@ -211,6 +212,22 @@ libpqrcv_connect(const char *conninfo, bool logical, const char *appname,
211212
returnNULL;
212213
}
213214

215+
if (logical)
216+
{
217+
PGresult*res;
218+
219+
res=libpqrcv_PQexec(conn->streamConn,
220+
ALWAYS_SECURE_SEARCH_PATH_SQL);
221+
if (PQresultStatus(res)!=PGRES_TUPLES_OK)
222+
{
223+
PQclear(res);
224+
ereport(ERROR,
225+
(errmsg("could not clear search path: %s",
226+
pchomp(PQerrorMessage(conn->streamConn)))));
227+
}
228+
PQclear(res);
229+
}
230+
214231
conn->logical=logical;
215232

216233
returnconn;

‎src/backend/replication/logical/worker.c‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1590,6 +1590,12 @@ ApplyWorkerMain(Datum main_arg)
15901590
BackgroundWorkerInitializeConnectionByOid(MyLogicalRepWorker->dbid,
15911591
MyLogicalRepWorker->userid);
15921592

1593+
/*
1594+
* Set always-secure search path, so malicious users can't redirect user
1595+
* code (e.g. pg_index.indexprs).
1596+
*/
1597+
SetConfigOption("search_path","",PGC_SUSET,PGC_S_OVERRIDE);
1598+
15931599
/* Load the subscription into persistent memory context. */
15941600
ApplyContext=AllocSetContextCreate(TopMemoryContext,
15951601
"ApplyContext",

‎src/test/subscription/t/001_rep_changes.pl‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@
1616
$node_subscriber->start;
1717

1818
# Create some preexisting content on publisher
19+
$node_publisher->safe_psql(
20+
'postgres',
21+
"CREATE FUNCTION public.pg_get_replica_identity_index(int)
22+
RETURNS regclass LANGUAGE sql AS 'SELECT 1/0'");# shall not call
1923
$node_publisher->safe_psql('postgres',
2024
"CREATE TABLE tab_notrep AS SELECT generate_series(1,10) AS a");
2125
$node_publisher->safe_psql('postgres',

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp