NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitdd16f94

committed

Remove unreachable code

The Solaris Studio compiler warns about these instances, unlike moremainstream compilers such as gcc. But manual inspection showed thatthe code is clearly not reachable, and we hope no worthy compiler willcomplain about removing this code.

1 parenta76c857 commitdd16f94Copy full SHA for dd16f94

File tree

20 files changed

-43

lines changed

contrib
- hstore
  - hstore_io.c
- intarray
  - _int_bool.c
  - _int_gist.c
- ltree
  - ltxtquery_io.c
  - ltxtquery_op.c
src
- backend
  - access
    - gin
      - ginbtree.c
      - ginget.c
    - gist
      - gistget.c
  - executor
    - nodeGroup.c
  - libpq
    - be-secure.c
  - storage/buffer
    - freelist.c
  - tcop
    - postgres.c
  - tsearch
    - dict_thesaurus.c
  - utils/adt
- bin
  - pg_basebackup
    - pg_receivexlog.c
  - psql
    - variables.c
- interfaces/ecpg/ecpglib
  - typename.c
- pl/plpgsql/src
  - pl_exec.c

20 files changed

-43

lines changed

`‎contrib/hstore/hstore_io.c‎`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -163,8 +163,6 @@ get_val(HSParser state, bool ignoreeq, bool escaped)`
`163`	`163`
`164`	`164`	`state->ptr++;`
`165`	`165`	`}`
`166`		`-`
`167`		`-return false;`
`168`	`166`	`}`
`169`	`167`
`170`	`168`	`#defineWKEY0`

`‎contrib/intarray/_int_bool.c‎`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,6 @@ gettoken(WORKSTATE state, int32 val)`
`136`	`136`	`}`
`137`	`137`	`(state->buf)++;`
`138`	`138`	`}`
`139`		`-returnEND;`
`140`	`139`	`}`
`141`	`140`
`142`	`141`	`/*`
`@@ -301,7 +300,6 @@ execute(ITEM curitem, void checkval, bool calcnot,`
`301`	`300`	`else`
`302`	`301`	`returnexecute(curitem-1,checkval,calcnot,chkcond);`
`303`	`302`	`}`
`304`		`-return false;`
`305`	`303`	`}`
`306`	`304`
`307`	`305`	`/*`
`@@ -404,7 +402,6 @@ contains_required_value(ITEM *curitem)`
`404`	`402`	`else`
`405`	`403`	`return false;`
`406`	`404`	`}`
`407`		`-return false;`
`408`	`405`	`}`
`409`	`406`
`410`	`407`	`bool`

`‎contrib/intarray/_int_gist.c‎`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -217,8 +217,6 @@ g_int_compress(PG_FUNCTION_ARGS)`
`217`	`217`	`}`
`218`	`218`	`else`
`219`	`219`	`PG_RETURN_POINTER(entry);`
`220`		`-`
`221`		`-PG_RETURN_POINTER(entry);`
`222`	`220`	`}`
`223`	`221`
`224`	`222`	`Datum`

`‎contrib/ltree/ltxtquery_io.c‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,6 @@ gettoken_query(QPRS_STATE state, int32 val, int32 lenval, char *strval, uint`
`139`	`139`
`140`	`140`	`state->buf+=charlen;`
`141`	`141`	`}`
`142`		`-returnEND;`
`143`	`142`	`}`
`144`	`143`
`145`	`144`	`/*`

`‎contrib/ltree/ltxtquery_op.c‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,6 @@ ltree_execute(ITEM curitem, void checkval, bool calcnot, bool (*chkcond) (void`
`40`	`40`	`else`
`41`	`41`	`returnltree_execute(curitem+1,checkval,calcnot,chkcond);`
`42`	`42`	`}`
`43`		`-return false;`
`44`	`43`	`}`
`45`	`44`
`46`	`45`	`typedefstruct`

`‎src/backend/access/gin/ginbtree.c‎`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -146,9 +146,6 @@ ginFindLeafPage(GinBtree btree, GinBtreeStack *stack)`
`146`	`146`	`stack->predictNumber=1;`
`147`	`147`	`}`
`148`	`148`	`}`
`149`		`-`
`150`		`-/* keep compiler happy */`
`151`		`-returnNULL;`
`152`	`149`	`}`
`153`	`150`
`154`	`151`	`void`

`‎src/backend/access/gin/ginget.c‎`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -354,8 +354,6 @@ collectMatchBitmap(GinBtreeData btree, GinBtreeStack stack,`
`354`	`354`	`*/`
`355`	`355`	`stack->off++;`
`356`	`356`	`}`
`357`		`-`
`358`		`-return true;`
`359`	`357`	`}`
`360`	`358`
`361`	`359`	`/*`

`‎src/backend/access/gist/gistget.c‎`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -535,8 +535,6 @@ gistgettuple(PG_FUNCTION_ARGS)`
`535`	`535`	`}while (so->nPageData==0);`
`536`	`536`	`}`
`537`	`537`	`}`
`538`		`-`
`539`		`-PG_RETURN_BOOL(false);/* keep compiler quiet */`
`540`	`538`	`}`
`541`	`539`
`542`	`540`	`/*`

`‎src/backend/executor/nodeGroup.c‎`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -184,9 +184,6 @@ ExecGroup(GroupState *node)`
`184`	`184`	`else`
`185`	`185`	`InstrCountFiltered1(node,1);`
`186`	`186`	`}`
`187`		`-`
`188`		`-/* NOTREACHED */`
`189`		`-returnNULL;`
`190`	`187`	`}`
`191`	`188`
`192`	`189`	`/* -----------------`

`‎src/backend/libpq/be-secure.c‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -201,9 +201,9 @@ secure_loaded_verify_locations(void)`
`201`	`201`	`{`
`202`	`202`	`#ifdefUSE_SSL`
`203`	`203`	`returnssl_loaded_verify_locations;`
`204`		`-#endif`
`205`		`-`
	`204`	`+#else`
`206`	`205`	`return false;`
	`206`	`+#endif`
`207`	`207`	`}`
`208`	`208`
`209`	`209`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdd16f94

File tree

20 files changed

20 files changed

`‎contrib/hstore/hstore_io.c‎`

`‎contrib/intarray/_int_bool.c‎`

`‎contrib/intarray/_int_gist.c‎`

`‎contrib/ltree/ltxtquery_io.c‎`

`‎contrib/ltree/ltxtquery_op.c‎`

`‎src/backend/access/gin/ginbtree.c‎`

`‎src/backend/access/gin/ginget.c‎`

`‎src/backend/access/gist/gistget.c‎`

`‎src/backend/executor/nodeGroup.c‎`

`‎src/backend/libpq/be-secure.c‎`

0 commit comments