forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitdd13ad9
committed
Fix use of cursor sensitivity terminology
Documentation and comments in code and tests have been using the termssensitive/insensitive cursor incorrectly relative to the SQL standard.(Cursor sensitivity is only relevant for changes made in the sametransaction as the cursor, not for concurrent changes in othersessions.) Moreover, some of the behavior of PostgreSQL is incorrectaccording to the SQL standard, confusing the issue further. (WHERECURRENT OF changes are not visible in insensitive cursors, but theyshould be.)This change corrects the terminology and removes the claim thatsensitive cursors are supported. It also adds a test case that checksthe insensitive behavior in a "correct" way, using a change commandnot using WHERE CURRENT OF. Finally, it adds the ASENSITIVE cursoroption to select the default asensitive behavior, per SQL standard.There are no changes to cursor behavior in this patch.Discussion:https://www.postgresql.org/message-id/flat/96ee8b30-9889-9e1b-b053-90e10c050e85%40enterprisedb.com1 parent0b5e824 commitdd13ad9
File tree
10 files changed
+105
-34
lines changed- doc/src/sgml
- ref
- src
- backend
- catalog
- parser
- bin/psql
- include
- nodes
- parser
- test/regress
- expected
- sql
10 files changed
+105
-34
lines changedLines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
6792 | 6792 |
| |
6793 | 6793 |
| |
6794 | 6794 |
| |
6795 |
| - | |
6796 |
| - | |
| 6795 | + | |
| 6796 | + | |
6797 | 6797 |
| |
6798 | 6798 |
| |
6799 | 6799 |
| |
|
Lines changed: 29 additions & 20 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
26 | 26 |
| |
27 | 27 |
| |
28 | 28 |
| |
29 |
| - | |
| 29 | + | |
30 | 30 |
| |
31 | 31 |
| |
32 | 32 |
| |
| |||
75 | 75 |
| |
76 | 76 |
| |
77 | 77 |
| |
| 78 | + | |
78 | 79 |
| |
79 | 80 |
| |
80 | 81 |
| |
81 |
| - | |
82 |
| - | |
83 |
| - | |
84 |
| - | |
85 |
| - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
86 | 97 |
| |
87 | 98 |
| |
88 | 99 |
| |
| |||
133 | 144 |
| |
134 | 145 |
| |
135 | 146 |
| |
136 |
| - | |
| 147 | + | |
137 | 148 |
| |
138 | 149 |
| |
139 | 150 |
| |
| |||
246 | 257 |
| |
247 | 258 |
| |
248 | 259 |
| |
249 |
| - | |
250 |
| - | |
251 |
| - | |
252 |
| - | |
| 260 | + | |
253 | 261 |
| |
254 | 262 |
| |
255 | 263 |
| |
| |||
278 | 286 |
| |
279 | 287 |
| |
280 | 288 |
| |
281 |
| - | |
| 289 | + | |
282 | 290 |
| |
283 | 291 |
| |
284 | 292 |
| |
| |||
318 | 326 |
| |
319 | 327 |
| |
320 | 328 |
| |
321 |
| - | |
322 |
| - | |
323 |
| - | |
324 |
| - | |
325 |
| - | |
326 |
| - | |
327 |
| - | |
328 |
| - | |
329 | 329 |
| |
330 | 330 |
| |
331 | 331 |
| |
332 | 332 |
| |
333 | 333 |
| |
334 | 334 |
| |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
335 | 344 |
| |
336 | 345 |
| |
337 | 346 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
452 | 452 |
| |
453 | 453 |
| |
454 | 454 |
| |
455 |
| - | |
| 455 | + | |
456 | 456 |
| |
457 | 457 |
| |
458 | 458 |
| |
|
Lines changed: 13 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2681 | 2681 |
| |
2682 | 2682 |
| |
2683 | 2683 |
| |
2684 |
| - | |
2685 |
| - | |
2686 |
| - | |
2687 | 2684 |
| |
2688 | 2685 |
| |
2689 | 2686 |
| |
2690 | 2687 |
| |
2691 |
| - | |
| 2688 | + | |
| 2689 | + | |
| 2690 | + | |
| 2691 | + | |
| 2692 | + | |
| 2693 | + | |
| 2694 | + | |
| 2695 | + | |
| 2696 | + | |
| 2697 | + | |
| 2698 | + | |
2692 | 2699 |
| |
2693 | 2700 |
| |
2694 | 2701 |
| |
| |||
2734 | 2741 |
| |
2735 | 2742 |
| |
2736 | 2743 |
| |
2737 |
| - | |
| 2744 | + | |
2738 | 2745 |
| |
2739 | 2746 |
| |
2740 |
| - | |
| 2747 | + | |
2741 | 2748 |
| |
2742 | 2749 |
| |
2743 | 2750 |
| |
|
Lines changed: 4 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
637 | 637 |
| |
638 | 638 |
| |
639 | 639 |
| |
640 |
| - | |
| 640 | + | |
641 | 641 |
| |
642 | 642 |
| |
643 | 643 |
| |
| |||
11217 | 11217 |
| |
11218 | 11218 |
| |
11219 | 11219 |
| |
| 11220 | + | |
11220 | 11221 |
| |
11221 | 11222 |
| |
11222 | 11223 |
| |
| |||
15424 | 15425 |
| |
15425 | 15426 |
| |
15426 | 15427 |
| |
| 15428 | + | |
15427 | 15429 |
| |
15428 | 15430 |
| |
15429 | 15431 |
| |
| |||
15931 | 15933 |
| |
15932 | 15934 |
| |
15933 | 15935 |
| |
| 15936 | + | |
15934 | 15937 |
| |
15935 | 15938 |
| |
15936 | 15939 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
3052 | 3052 |
| |
3053 | 3053 |
| |
3054 | 3054 |
| |
3055 |
| - | |
| 3055 | + | |
3056 | 3056 |
| |
3057 | 3057 |
| |
3058 | 3058 |
| |
|
Lines changed: 2 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2774 | 2774 |
| |
2775 | 2775 |
| |
2776 | 2776 |
| |
2777 |
| - | |
| 2777 | + | |
| 2778 | + | |
2778 | 2779 |
| |
2779 | 2780 |
| |
2780 | 2781 |
| |
|
Lines changed: 1 addition & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
44 | 44 |
| |
45 | 45 |
| |
46 | 46 |
| |
| 47 | + | |
47 | 48 |
| |
48 | 49 |
| |
49 | 50 |
| |
|
Lines changed: 36 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1094 | 1094 |
| |
1095 | 1095 |
| |
1096 | 1096 |
| |
1097 |
| - | |
| 1097 | + | |
1098 | 1098 |
| |
1099 | 1099 |
| |
1100 | 1100 |
| |
| |||
1106 | 1106 |
| |
1107 | 1107 |
| |
1108 | 1108 |
| |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
| 1118 | + | |
| 1119 | + | |
| 1120 | + | |
| 1121 | + | |
| 1122 | + | |
| 1123 | + | |
| 1124 | + | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
| 1133 | + | |
| 1134 | + | |
| 1135 | + | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
1109 | 1144 |
| |
1110 | 1145 |
| |
1111 | 1146 |
| |
|
Lines changed: 16 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
382 | 382 |
| |
383 | 383 |
| |
384 | 384 |
| |
385 |
| - | |
| 385 | + | |
386 | 386 |
| |
387 | 387 |
| |
388 | 388 |
| |
389 | 389 |
| |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
390 | 405 |
| |
391 | 406 |
| |
392 | 407 |
| |
|
0 commit comments
Comments
(0)