NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitdcfecaa

committed

Fix parallel query on standby servers.

Without this fix, it inevitably bombs out with "ERROR: failed toinitialize transaction_read_only to 0". Repair.Ashutosh Sharma; comments adjusted by me.

1 parent070140e commitdcfecaaCopy full SHA for dcfecaa

File tree

1 file changed

-1

lines changed

src/backend/commands
- variable.c

1 file changed

-1

lines changed

`‎src/backend/commands/variable.c‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -482,11 +482,13 @@ show_log_timezone(void)`
`482`	`482`	`* nothing since XactReadOnly will be reset by the next StartTransaction().`
`483`	`483`	`* The IsTransactionState() test protects us against trying to check`
`484`	`484`	`* RecoveryInProgress() in contexts where shared memory is not accessible.`
	`485`	`+ * (Similarly, if we're restoring state in a parallel worker, just allow`
	`486`	`+ * the change.)`
`485`	`487`	`*/`
`486`	`488`	`bool`
`487`	`489`	`check_transaction_read_only(boolnewval,void*extra,GucSourcesource)`
`488`	`490`	`{`
`489`		`-if (*newval== false&&XactReadOnly&&IsTransactionState())`
	`491`	`+if (*newval== false&&XactReadOnly&&IsTransactionState()&& !InitializingParallelWorker)`
`490`	`492`	`{`
`491`	`493`	`/* Can't go to r/w mode inside a r/o transaction */`
`492`	`494`	`if (IsSubTransaction())`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdcfecaa

File tree

1 file changed

1 file changed

`‎src/backend/commands/variable.c‎`

0 commit comments