Commitdcfc49c

committed

Remove dubious warning message from SQL/JSON functions

There was a warning that FORMAT JSON has no effect on json/jsonbtypes, which is true, but it's not clear why we should issue a warningabout it. The SQL standard does not say anything about this, whichshould generally govern the behavior here. So remove it.Discussion:https://www.postgresql.org/message-id/flat/dfec2cae-d17e-c508-6d16-c2dba82db486%40eisentraut.org

1 parent6337e99 commitdcfc49cCopy full SHA for dcfc49c

File tree

-11

lines changed

-11

lines changed

Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -3240,12 +3240,7 @@ transformJsonValueExpr(ParseState pstate, const char constructName,`
`3240`	`3240`	`parser_errposition(pstate,ve->format->location));`
`3241`	`3241`
`3242`	`3242`	`if (exprtype==JSONOID\|\|exprtype==JSONBOID)`
`3243`		`-{`
`3244`	`3243`	`format=JS_FORMAT_DEFAULT;/* do not format json[b] types */`
`3245`		`-ereport(WARNING,`
`3246`		`-errmsg("FORMAT JSON has no effect for json and jsonb types"),`
`3247`		`-parser_errposition(pstate,ve->format->location));`
`3248`		`-}`
`3249`	`3244`	`else`
`3250`	`3245`	`format=ve->format->format_type;`
`3251`	`3246`	`}`

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -84,9 +84,6 @@ ERROR: JSON ENCODING clause is only allowed for bytea input type`
`84`	`84`	`LINE 1: SELECT JSON_OBJECT('foo': NULL::int FORMAT JSON ENCODING UTF...`
`85`	`85`	`^`
`86`	`86`	`SELECT JSON_OBJECT('foo': NULL::json FORMAT JSON);`
`87`		`-WARNING: FORMAT JSON has no effect for json and jsonb types`
`88`		`-LINE 1: SELECT JSON_OBJECT('foo': NULL::json FORMAT JSON);`
`89`		`- ^`
`90`	`87`	`json_object`
`91`	`88`	`----------------`
`92`	`89`	`{"foo" : null}`
`@@ -97,9 +94,6 @@ ERROR: JSON ENCODING clause is only allowed for bytea input type`
`97`	`94`	`LINE 1: SELECT JSON_OBJECT('foo': NULL::json FORMAT JSON ENCODING UT...`
`98`	`95`	`^`
`99`	`96`	`SELECT JSON_OBJECT('foo': NULL::jsonb FORMAT JSON);`
`100`		`-WARNING: FORMAT JSON has no effect for json and jsonb types`
`101`		`-LINE 1: SELECT JSON_OBJECT('foo': NULL::jsonb FORMAT JSON);`
`102`		`- ^`
`103`	`97`	`json_object`
`104`	`98`	`---------------`
`105`	`99`	`{"foo": null}`

Comments

(0)