Commitdcecdfa

Amit Kapila

committed

Update comments for AlterSubscription.

Add explanation as to why the subscription needs to be disabled to allowslot_name as none.Author: Japin Li and Amit KapilaDiscussion:https://postgr.es/m/MEYP282MB1669CBD98E721C77CA696499B61A9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM

1 parent2dbe890 commitdcecdfaCopy full SHA for dcecdfa

File tree

-0

lines changed

-0

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -894,6 +894,13 @@ AlterSubscription(ParseState pstate, AlterSubscriptionStmt stmt,`
`894`	`894`
`895`	`895`	`if (IsSet(opts.specified_opts,SUBOPT_SLOT_NAME))`
`896`	`896`	`{`
	`897`	`+/*`
	`898`	`+ * The subscription must be disabled to allow slot_name as`
	`899`	`+ * 'none', otherwise, the apply worker will repeatedly try`
	`900`	`+ * to stream the data using that slot_name which neither`
	`901`	`+ * exists on the publisher nor the user will be allowed to`
	`902`	`+ * create it.`
	`903`	`+ */`
`897`	`904`	`if (sub->enabled&& !opts.slot_name)`
`898`	`905`	`ereport(ERROR,`
`899`	`906`	`(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),`

Comments

(0)