Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitdcd4454

Browse files
committed
Remove unnecessary dependencies to wal_level=logical in TAP tests
A couple of TAP tests make use of wal_level=logical for nodes that donot need to do any kind of logical decoding operations, likesubscription nodes on which changes are only applied. This can beconfusing when reading these tests as setup examples, so let's removethis configuration where not required (contrary to two-way logicalreplication and similar more complex cases). This simplifies the testsa bit, making them slightly cheaper with less WAL generated overall.Author: Hayato KurodaDiscussion:https://postgr.es/m/TYAPR01MB5866946BCEB747ABE513ACC6F5D5A@TYAPR01MB5866.jpnprd01.prod.outlook.com
1 parentafd1277 commitdcd4454

32 files changed

+34
-38
lines changed

‎src/test/recovery/t/035_standby_logical_decoding.pl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ sub check_for_invalidation
293293
#######################
294294
# Initialize subscriber node
295295
#######################
296-
$node_subscriber->init(allows_streaming=>'logical');
296+
$node_subscriber->init;
297297
$node_subscriber->start;
298298

299299
my%psql_subscriber = (

‎src/test/recovery/t/038_save_logical_slots_shutdown.pl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ sub compare_confirmed_flush
5353

5454
# Create subscriber node
5555
my$node_subscriber = PostgreSQL::Test::Cluster->new('sub');
56-
$node_subscriber->init(allows_streaming=>'logical');
56+
$node_subscriber->init;
5757
$node_subscriber->start;
5858

5959
# Create tables

‎src/test/subscription/t/001_rep_changes.pl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
# Create subscriber node
1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(allows_streaming=>'logical');
18+
$node_subscriber->init;
1919
$node_subscriber->start;
2020

2121
# Create some preexisting content on publisher

‎src/test/subscription/t/002_types.pl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
# Create subscriber node
1818
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
19-
$node_subscriber->init(allows_streaming=>'logical');
19+
$node_subscriber->init;
2020
$node_subscriber->start;
2121

2222
# Create some preexisting content on publisher

‎src/test/subscription/t/003_constraints.pl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
# Create subscriber node
1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(allows_streaming=>'logical');
18+
$node_subscriber->init;
1919
$node_subscriber->start;
2020

2121
# Setup structure on publisher

‎src/test/subscription/t/004_sync.pl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
# Create subscriber node
1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(allows_streaming=>'logical');
18+
$node_subscriber->init;
1919
$node_subscriber->append_conf('postgresql.conf',
2020
"wal_retrieve_retry_interval = 1ms");
2121
$node_subscriber->start;

‎src/test/subscription/t/005_encoding.pl‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@
1515
$node_publisher->start;
1616

1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(
19-
allows_streaming=>'logical',
20-
extra=> ['--locale=C','--encoding=LATIN1' ]);
18+
$node_subscriber->init(extra=> ['--locale=C','--encoding=LATIN1' ]);
2119
$node_subscriber->start;
2220

2321
my$ddl ="CREATE TABLE test1 (a int, b text);";

‎src/test/subscription/t/006_rewrite.pl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
$node_publisher->start;
1414

1515
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
16-
$node_subscriber->init(allows_streaming=>'logical');
16+
$node_subscriber->init;
1717
$node_subscriber->start;
1818

1919
my$ddl ="CREATE TABLE test1 (a int, b text);";

‎src/test/subscription/t/007_ddl.pl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
$node_publisher->start;
1414

1515
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
16-
$node_subscriber->init(allows_streaming=>'logical');
16+
$node_subscriber->init;
1717
$node_subscriber->start;
1818

1919
my$ddl ="CREATE TABLE test1 (a int, b text);";

‎src/test/subscription/t/008_diff_schema.pl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
# Create subscriber node
1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(allows_streaming=>'logical');
18+
$node_subscriber->init;
1919
$node_subscriber->start;
2020

2121
# Create some preexisting content on publisher

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp