NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitdcd052c

committed

Fix pg_atomic_u64 initialization.

As Andres pointed out, pg_atomic_init_u64 must be used to initialize anatomic variable, before it can be accessed with the actual atomic ops.Trying to use pg_atomic_write_u64 on an uninitialized variable leads to afailure with the fallback implementation that uses a spinlock.Discussion:https://www.postgresql.org/message-id/20170816191346.d3ke5tpshhco4bnd%40alap3.anarazel.de

1 parentec0a69e commitdcd052cCopy full SHA for dcd052c

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1638,7 +1638,7 @@ heap_parallelscan_initialize(ParallelHeapScanDesc target, Relation relation,`
`1638`	`1638`	`target->phs_nblocks>NBuffers /4;`
`1639`	`1639`	`SpinLockInit(&target->phs_mutex);`
`1640`	`1640`	`target->phs_startblock=InvalidBlockNumber;`
`1641`		`-pg_atomic_write_u64(&target->phs_nallocated,0);`
	`1641`	`+pg_atomic_init_u64(&target->phs_nallocated,0);`
`1642`	`1642`	`SerializeSnapshot(snapshot,target->phs_snapshot_data);`
`1643`	`1643`	`}`
`1644`	`1644`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdcd052c

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c`

0 commit comments