forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitdca992d
committed
Fix portability issue in pg_upgrade test script: avoid $PWD.
SUSv2-era shells don't set the PWD variable, though anything more moderndoes. In the buildfarm environment this could lead to test.sh executingwith PWD pointing to $HOME or another high-level directory, so that therewere conflicts between concurrent executions of the test in differentbranch subdirectories. This appears to be the explanation for recentintermittent failures on buildfarm members binturong and dingo (and mightwell have something to do with the buildfarm script's failure to capturelog files from pg_upgrade tests, too).To fix, just use `pwd` in place of $PWD. AFAICS test.sh is the only placein our source tree that depended on $PWD. Back-patch to all versionscontaining this script.Per buildfarm. Thanks to Oskari Saarenmaa for diagnosing the problem.1 parentfcdac56 commitdca992d
1 file changed
+3
-2
lines changedLines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
| 66 | + | |
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| |||
105 | 106 | | |
106 | 107 | | |
107 | 108 | | |
108 | | - | |
| 109 | + | |
109 | 110 | | |
110 | 111 | | |
111 | 112 | | |
| |||
0 commit comments
Comments
(0)