Commitdc961e5

committed

Fix error message when a hostaddr cannot be parsed.

We were incorrectly passing hostname, not hostaddr, in the error message,and because of that, you got:$ psql 'hostaddr=foo'psql: could not parse network address "(null)": Name or service not knownBackpatch to v10, where this was broken (by commit7b02ba6).Report and fix by Robert Haas.Discussion:https://www.postgresql.org/message-id/CA+TgmoapFQA30NomGKEaZCu3iN7mF7fux8fbbk9SouVOT2JP7w@mail.gmail.com

1 parent45fcd75 commitdc961e5Copy full SHA for dc961e5

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1751,7 +1751,7 @@ connectDBStart(PGconn *conn)`
`1751`	`1751`	`if (ret\|\| !ch->addrlist)`
`1752`	`1752`	`appendPQExpBuffer(&conn->errorMessage,`
`1753`	`1753`	`libpq_gettext("could not parse network address \"%s\": %s\n"),`
`1754`		`-ch->host,gai_strerror(ret));`
	`1754`	`+ch->hostaddr,gai_strerror(ret));`
`1755`	`1755`	`break;`
`1756`	`1756`
`1757`	`1757`	`caseCHT_UNIX_SOCKET:`

Comments

(0)