NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitdc878ff

committed

Remove spurious code comments in standby related code

GetRunningTransactionData() suggested that subxids were not worthoptimizing away if overflowed, yet they have already been removedfor that case.Changes to LogAccessExclusiveLock() API forgot to remove theprior comment when it was copied to LockAcquire().

1 parent802bde8 commitdc878ffCopy full SHA for dc878ff

File tree

2 files changed

-8

lines changed

src/backend/storage/ipc
- procarray.c
- standby.c

2 files changed

-8

lines changed

`‎src/backend/storage/ipc/procarray.c`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1926,9 +1926,7 @@ ProcArrayInstallRestoredXmin(TransactionId xmin, PGPROC *proc)`
`1926`	`1926`	`* that bookkeeping.`
`1927`	`1927`	`*`
`1928`	`1928`	`* Note that if any transaction has overflowed its cached subtransactions`
`1929`		`- * then there is no real need include any subtransactions. That isn't a`
`1930`		`- * common enough case to worry about optimising the size of the WAL record,`
`1931`		`- * and we may wish to see that data for diagnostic purposes anyway.`
	`1929`	`+ * then there is no real need include any subtransactions.`
`1932`	`1930`	`*/`
`1933`	`1931`	`RunningTransactions`
`1934`	`1932`	`GetRunningTransactionData(void)`

`‎src/backend/storage/ipc/standby.c`

Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1050,11 +1050,6 @@ LogAccessExclusiveLock(Oid dbOid, Oid relOid)`
`1050`	`1050`
`1051`	`1051`	`xlrec.xid=GetCurrentTransactionId();`
`1052`	`1052`
`1053`		`-/*`
`1054`		`- * Decode the locktag back to the original values, to avoid sending lots`
`1055`		`- * of empty bytes with every message. See lock.h to check how a locktag`
`1056`		`- * is defined for LOCKTAG_RELATION`
`1057`		`- */`
`1058`	`1053`	`xlrec.dbOid=dbOid;`
`1059`	`1054`	`xlrec.relOid=relOid;`
`1060`	`1055`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdc878ff

File tree

2 files changed

2 files changed

`‎src/backend/storage/ipc/procarray.c`

`‎src/backend/storage/ipc/standby.c`

0 commit comments