NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitdc227eb

committed

Add a build-time check that libpq doesn't call exit() or abort().

Directly exiting or aborting seems like poor form for a general-purposelibrary. Now that libpq liberally uses bits out of src/common/,it's very easy to accidentally include code that would do somethingunwanted like calling exit(1) after OOM --- see for example8ec00dc.Hence, add a simple cross-check that no such calls have made it intolibpq.so.The cross-check depends on nm(1) being available and being able towork on a shared library, which probably isn't true everywhere.But we can just make the test silently do nothing if nm fails.As long as the check is effective on common platforms, that shouldbe good enough. (By the same logic, I've not worried about providingan equivalent test in MSVC builds.)Discussion:https://postgr.es/m/3128896.1624742969@sss.pgh.pa.us

1 parentaaddf6b commitdc227ebCopy full SHA for dc227eb

File tree

1 file changed

-1

lines changed

src/interfaces/libpq
- Makefile

1 file changed

-1

lines changed

`‎src/interfaces/libpq/Makefile`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -96,12 +96,19 @@ SHLIB_EXPORTS = exports.txt`
`96`	`96`
`97`	`97`	`PKG_CONFIG_REQUIRES_PRIVATE = libssl libcrypto`
`98`	`98`
`99`		`-all: all-lib`
	`99`	`+all: all-lib check-libpq-refs`
`100`	`100`
`101`	`101`	`# Shared library stuff`
`102`	`102`	`include$(top_srcdir)/src/Makefile.shlib`
`103`	`103`	`backend_src =$(top_srcdir)/src/backend`
`104`	`104`
	`105`	`+# Check for functions that libpq must not call, currently abort() and exit().`
	`106`	`+# If nm doesn't exist or doesn't work on shlibs, this test will silently`
	`107`	`+# do nothing, which is fine. The exclusion of _eprintf.o is to prevent`
	`108`	`+# complaining about <assert.h> infrastructure on ancient macOS releases.`
	`109`	`+.PHONY: check-libpq-refs`
	`110`	`+check-libpq-refs:$(shlib)`
	`111`	`+! nm -A -g -u$<2>/dev/null\| grep -v'_eprintf\.o:'\| grep -e abort -eexit`
`105`	`112`
`106`	`113`	`# Make dependencies on pg_config_paths.h visible in all builds.`
`107`	`114`	`fe-connect.o: fe-connect.c$(top_builddir)/src/port/pg_config_paths.h`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdc227eb

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/Makefile`

0 commit comments