Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitdbe8a17

Browse files
committed
Remove SQL regression tests for GUCs related to NO_SHOW_ALL
No GUCs that use NO_SHOW_ALL are reported in pg_show_all_settings(),hence trying to check combinations of flags related to it is pointless.These queries have been introduced byd10e41d, so backpatch down to 15to keep all the branches consistent. Equivalent checks based onNO_SHOW_ALL could be added in check_GUC_init() when a GUC is initiallyloaded, but this can be done only on HEAD.Author: Nitin JadhavDiscussion:https://postgr.es/m/CAMm1aWaYe0muu3ABo7iSAgK+OWDS9yNe8GGRYnCyeEpScYKa+g@mail.gmail.comBackpatch-through: 15
1 parent78ec02d commitdbe8a17

File tree

2 files changed

+0
-41
lines changed

2 files changed

+0
-41
lines changed

‎src/test/regress/expected/guc.out

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -840,7 +840,6 @@ SELECT pg_settings_get_flags('does_not_exist');
840840
CREATE TABLE tab_settings_flags AS SELECT name, category,
841841
'EXPLAIN' = ANY(flags) AS explain,
842842
'NO_RESET_ALL' = ANY(flags) AS no_reset_all,
843-
'NO_SHOW_ALL' = ANY(flags) AS no_show_all,
844843
'NOT_IN_SAMPLE' = ANY(flags) AS not_in_sample,
845844
'RUNTIME_COMPUTED' = ANY(flags) AS runtime_computed
846845
FROM pg_show_all_settings() AS psas,
@@ -879,31 +878,4 @@ SELECT name FROM tab_settings_flags
879878
------
880879
(0 rows)
881880

882-
-- NO_SHOW_ALL implies NO_RESET_ALL, and vice-versa.
883-
SELECT name FROM tab_settings_flags
884-
WHERE no_show_all AND NOT no_reset_all
885-
ORDER BY 1;
886-
name
887-
------
888-
(0 rows)
889-
890-
-- Exceptions are transaction_*.
891-
SELECT name FROM tab_settings_flags
892-
WHERE NOT no_show_all AND no_reset_all
893-
ORDER BY 1;
894-
name
895-
------------------------
896-
transaction_deferrable
897-
transaction_isolation
898-
transaction_read_only
899-
(3 rows)
900-
901-
-- NO_SHOW_ALL implies NOT_IN_SAMPLE.
902-
SELECT name FROM tab_settings_flags
903-
WHERE no_show_all AND NOT not_in_sample
904-
ORDER BY 1;
905-
name
906-
------
907-
(0 rows)
908-
909881
DROP TABLE tab_settings_flags;

‎src/test/regress/sql/guc.sql

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,6 @@ SELECT pg_settings_get_flags('does_not_exist');
325325
CREATETABLEtab_settings_flagsASSELECT name, category,
326326
'EXPLAIN'= ANY(flags)AS explain,
327327
'NO_RESET_ALL'= ANY(flags)AS no_reset_all,
328-
'NO_SHOW_ALL'= ANY(flags)AS no_show_all,
329328
'NOT_IN_SAMPLE'= ANY(flags)AS not_in_sample,
330329
'RUNTIME_COMPUTED'= ANY(flags)AS runtime_computed
331330
FROM pg_show_all_settings()AS psas,
@@ -348,16 +347,4 @@ SELECT name FROM tab_settings_flags
348347
SELECT nameFROM tab_settings_flags
349348
WHERE category='Preset Options'AND NOT not_in_sample
350349
ORDER BY1;
351-
-- NO_SHOW_ALL implies NO_RESET_ALL, and vice-versa.
352-
SELECT nameFROM tab_settings_flags
353-
WHERE no_show_allAND NOT no_reset_all
354-
ORDER BY1;
355-
-- Exceptions are transaction_*.
356-
SELECT nameFROM tab_settings_flags
357-
WHERE NOT no_show_allAND no_reset_all
358-
ORDER BY1;
359-
-- NO_SHOW_ALL implies NOT_IN_SAMPLE.
360-
SELECT nameFROM tab_settings_flags
361-
WHERE no_show_allAND NOT not_in_sample
362-
ORDER BY1;
363350
DROPTABLE tab_settings_flags;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp