NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitdbbca2c

committed

Remove unused #include's from backend .c files

as determined by include-what-you-use (IWYU)While IWYU also suggests to *add* a bunch of #include's (which is itsmain purpose), this patch does not do that. In some cases, a morespecific #include replaces another less specific one.Some manual adjustments of the automatic result:- IWYU currently doesn't know about includes that provide global variable declarations (like -Wmissing-variable-declarations), so those includes are being kept manually.- All includes for port(ability) headers are being kept for now, to play it safe.- No changes of catalog/pg_foo.h to catalog/pg_foo_d.h, to keep the patch from exploding in size.Note that this patch touches just *.c files, so nothing declared inheader files changes in hidden ways.As a small example, in src/backend/access/transam/rmgr.c, some IWYUpragma annotations are added to handle a special case there.Discussion:https://www.postgresql.org/message-id/flat/af837490-6b2f-46df-ba05-37ea6a6653fc%40eisentraut.org

1 parent24eebc6 commitdbbca2cCopy full SHA for dbbca2c

File tree

425 files changed

+230

-994

lines changed

src/backend
- access
  - brin
  - common
  - gin
  - gist
  - hash
  - heap
  - index
  - nbtree
  - rmgrdesc
  - spgist
  - tablesample
    - bernoulli.c
    - system.c
  - table
  - transam
- backup
  - backup_manifest.c
  - basebackup.c
  - basebackup_incremental.c
  - basebackup_progress.c
  - basebackup_server.c
- bootstrap
  - bootstrap.c
- catalog
  - aclchk.c
  - catalog.c
  - dependency.c
  - index.c
  - namespace.c
  - objectaddress.c
  - partition.c
  - pg_collation.c
  - pg_constraint.c
  - pg_conversion.c
  - pg_inherits.c
  - pg_largeobject.c
  - pg_parameter_acl.c
  - pg_proc.c
  - pg_publication.c
  - pg_shdepend.c
  - pg_subscription.c
  - pg_type.c
  - storage.c
  - toasting.c
- commands
  - aggregatecmds.c
  - alter.c
  - analyze.c
  - async.c
  - cluster.c
  - collationcmds.c
  - constraint.c
  - conversioncmds.c
  - copy.c
  - copyfrom.c
  - copyfromparse.c
  - copyto.c
  - createas.c
  - dbcommands.c
  - define.c
  - dropcmds.c
  - event_trigger.c
  - explain.c
  - extension.c
  - functioncmds.c
  - indexcmds.c
  - lockcmds.c
  - matview.c
  - opclasscmds.c
  - operatorcmds.c
  - policy.c
  - prepare.c
  - proclang.c
  - publicationcmds.c
  - statscmds.c
  - tablecmds.c
  - tablespace.c
  - trigger.c
  - tsearchcmds.c
  - typecmds.c
  - user.c
  - vacuum.c
  - vacuumparallel.c
  - variable.c
  - view.c
- executor
  - execAmi.c
  - execExpr.c
  - execExprInterp.c
  - execGrouping.c
  - execMain.c
  - execParallel.c
  - execPartition.c
  - execReplication.c
  - execSRF.c
  - execScan.c
  - execUtils.c
  - nodeAgg.c
  - nodeAppend.c
  - nodeBitmapAnd.c
  - nodeBitmapHeapscan.c
  - nodeBitmapIndexscan.c
  - nodeBitmapOr.c
  - nodeCtescan.c
  - nodeCustom.c
  - nodeForeignscan.c
  - nodeFunctionscan.c
  - nodeGather.c
  - nodeGatherMerge.c
  - nodeGroup.c
  - nodeHash.c
  - nodeHashjoin.c
  - nodeIncrementalSort.c
  - nodeIndexonlyscan.c
  - nodeIndexscan.c
  - nodeLimit.c
  - nodeMergeAppend.c
  - nodeMergejoin.c
  - nodeModifyTable.c
  - nodeNamedtuplestorescan.c
  - nodeNestloop.c
  - nodeProjectSet.c
  - nodeRecursiveunion.c
  - nodeResult.c
  - nodeSamplescan.c
  - nodeSeqscan.c
  - nodeSubqueryscan.c
  - nodeTidrangescan.c
  - nodeTidscan.c
  - nodeUnique.c
  - nodeWorktablescan.c
  - spi.c
- foreign
  - foreign.c
- jit
  - jit.c
- libpq
  - auth-scram.c
  - auth.c
  - be-secure.c
  - crypt.c
  - hba.c
- lib
  - dshash.c
  - integerset.c
  - knapsack.c
- main
  - main.c
- nodes
  - makefuncs.c
  - nodeFuncs.c
- optimizer
  - geqo
  - path
  - plan
  - prep
  - util
- parser
  - analyze.c
  - parse_clause.c
  - parse_merge.c
  - parse_node.c
  - parse_target.c
- partitioning
  - partbounds.c
  - partdesc.c
  - partprune.c
- port
  - sysv_shmem.c
- postmaster
  - autovacuum.c
  - auxprocess.c
  - bgworker.c
  - bgwriter.c
  - postmaster.c
  - startup.c
  - syslogger.c
  - walsummarizer.c
- replication
  - libpqwalreceiver
    - libpqwalreceiver.c
  - logical
  - pgoutput
    - pgoutput.c
  - syncrep.c
  - walreceiver.c
  - walreceiverfuncs.c
  - walsender.c
- rewrite
  - rewriteDefine.c
  - rewriteHandler.c
  - rewriteRemove.c
  - rewriteSupport.c
  - rowsecurity.c
- snowball
  - dict_snowball.c
- statistics
  - dependencies.c
  - extended_stats.c
  - mcv.c
  - mvdistinct.c
- storage
  - buffer
  - file
  - freespace
    - freespace.c
  - ipc
  - large_object
    - inv_api.c
  - lmgr
  - smgr
    - md.c
    - smgr.c
  - sync
    - sync.c
- tcop
  - cmdtag.c
  - dest.c
  - fastpath.c
  - utility.c
- tsearch
  - dict.c
  - dict_ispell.c
  - dict_simple.c
  - dict_synonym.c
  - dict_thesaurus.c
  - to_tsany.c
  - ts_locale.c
  - ts_selfuncs.c
  - ts_utils.c
  - wparser.c
  - wparser_def.c
- utils
  - activity
  - adt
  - cache
  - error
  - init
    - miscinit.c
    - postinit.c
  - mb
    - mbutils.c
  - misc
  - mmgr
  - sort
  - time
    - snapmgr.c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

425 files changed

+230

-994

lines changed

`‎src/backend/access/brin/brin.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,8 @@`
`35`	`35`	`#include"storage/freespace.h"`
`36`	`36`	`#include"tcop/tcopprot.h"/* pgrminclude ignore */`
`37`	`37`	`#include"utils/acl.h"`
`38`		`-#include"utils/builtins.h"`
`39`	`38`	`#include"utils/datum.h"`
	`39`	`+#include"utils/fmgrprotos.h"`
`40`	`40`	`#include"utils/guc.h"`
`41`	`41`	`#include"utils/index_selfuncs.h"`
`42`	`42`	`#include"utils/memutils.h"`

`‎src/backend/access/brin/brin_bloom.c‎`

Lines changed: 3 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -119,17 +119,14 @@`
`119`	`119`	`#include"access/brin_internal.h"`
`120`	`120`	`#include"access/brin_page.h"`
`121`	`121`	`#include"access/brin_tuple.h"`
`122`		`-#include"access/hash.h"`
`123`	`122`	`#include"access/htup_details.h"`
`124`	`123`	`#include"access/reloptions.h"`
`125`		`-#include"access/stratnum.h"`
	`124`	`+#include"catalog/pg_am.h"`
`126`	`125`	`#include"catalog/pg_type.h"`
`127`	`126`	`#include"catalog/pg_amop.h"`
`128`		`-#include"utils/builtins.h"`
`129`		`-#include"utils/datum.h"`
`130`		`-#include"utils/lsyscache.h"`
	`127`	`+#include"common/hashfn.h"`
	`128`	`+#include"utils/fmgrprotos.h"`
`131`	`129`	`#include"utils/rel.h"`
`132`		`-#include"utils/syscache.h"`
`133`	`130`
`134`	`131`	`#include<math.h>`
`135`	`132`

`‎src/backend/access/brin/brin_inclusion.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,8 @@`
`30`	`30`	`#include"access/skey.h"`
`31`	`31`	`#include"catalog/pg_amop.h"`
`32`	`32`	`#include"catalog/pg_type.h"`
`33`		`-#include"utils/builtins.h"`
`34`	`33`	`#include"utils/datum.h"`
	`34`	`+#include"utils/fmgrprotos.h"`
`35`	`35`	`#include"utils/lsyscache.h"`
`36`	`36`	`#include"utils/rel.h"`
`37`	`37`	`#include"utils/syscache.h"`