NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitdb8e366

committed

Suppress more variable-set-but-not-used warnings from clang 15.

Mop up assorted set-but-not-used warnings in the back branches.This includes back-patching relevant fixes from commit152c9f7the rest of the way, but there are also several cases that did notappear in HEAD. Some of those we'd fixed in a retail way but notback-patched, and others I think just got rewritten out of existenceduring nearby refactoring.While here, also back-patchb1980f6 (PL/Tcl: Fix compiler warningswith Tcl 8.6) into 9.2, so that that branch compiles warning-freewith modern Tcl.Per project policy, this is a candidate for back-patching intoout-of-support branches: it suppresses annoying compiler warningsbut changes no behavior. Hence, back-patch all the way to 9.2.Discussion:https://postgr.es/m/514615.1663615243@sss.pgh.pa.us

1 parent43f72e0 commitdb8e366Copy full SHA for db8e366

File tree

2 files changed

-7

lines changed

src/backend
- optimizer/util
  - var.c
- utils/cache
  - relcache.c

2 files changed

-7

lines changed

`‎src/backend/optimizer/util/var.c`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -773,16 +773,13 @@ flatten_join_alias_vars_mutator(Node *node,`
`773`	`773`	`RowExpr*rowexpr;`
`774`	`774`	`List*fields=NIL;`
`775`	`775`	`List*colnames=NIL;`
`776`		`-AttrNumberattnum;`
`777`	`776`	`ListCell*lv;`
`778`	`777`	`ListCell*ln;`
`779`	`778`
`780`		`-attnum=0;`
`781`	`779`	`Assert(list_length(rte->joinaliasvars)==list_length(rte->eref->colnames));`
`782`	`780`	`forboth(lv,rte->joinaliasvars,ln,rte->eref->colnames)`
`783`	`781`	`{`
`784`	`782`	`newvar= (Node*)lfirst(lv);`
`785`		`-attnum++;`
`786`	`783`	`/* Ignore dropped columns */`
`787`	`784`	`if (newvar==NULL)`
`788`	`785`	`continue;`

`‎src/backend/utils/cache/relcache.c`

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -4373,7 +4373,6 @@ AttrDefaultFetch(Relation relation)`
`4373`	`4373`	`HeapTuplehtup;`
`4374`	`4374`	`Datumval;`
`4375`	`4375`	`boolisnull;`
`4376`		`-intfound;`
`4377`	`4376`	`inti;`
`4378`	`4377`
`4379`	`4378`	`ScanKeyInit(&skey,`
`@@ -4384,7 +4383,6 @@ AttrDefaultFetch(Relation relation)`
`4384`	`4383`	`adrel=table_open(AttrDefaultRelationId,AccessShareLock);`
`4385`	`4384`	`adscan=systable_beginscan(adrel,AttrDefaultIndexId, true,`
`4386`	`4385`	`NULL,1,&skey);`
`4387`		`-found=0;`
`4388`	`4386`
`4389`	`4387`	`while (HeapTupleIsValid(htup=systable_getnext(adscan)))`
`4390`	`4388`	`{`
`@@ -4399,8 +4397,6 @@ AttrDefaultFetch(Relation relation)`
`4399`	`4397`	`elog(WARNING,"multiple attrdef records found for attr %s of rel %s",`
`4400`	`4398`	`NameStr(attr->attname),`
`4401`	`4399`	`RelationGetRelationName(relation));`
`4402`		`-else`
`4403`		`-found++;`
`4404`	`4400`
`4405`	`4401`	`val=fastgetattr(htup,`
`4406`	`4402`	`Anum_pg_attrdef_adbin,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdb8e366

File tree

2 files changed

2 files changed

`‎src/backend/optimizer/util/var.c`

`‎src/backend/utils/cache/relcache.c`

0 commit comments