NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitdb7c7b8

committed

Improve stability of identity.sql regression test.

I noticed while trying to run the regression tests under a lowgeqo_threshold that one query on information_schema.columns hadunstable (as in, variable from one run to the next) output order.This is pretty unsurprising given the complexity of the underlyingplan. Interestingly, of this test's three nigh-identical queries oninformation_schema.columns, the other two already had ORDER BY clausesguaranteeing stable output. Let's make this one look the same.Back-patch to v10 where this test was added. We've not heard fieldreports of the test failing, but this experience shows that it canhappen when testing under even slightly unusual conditions.

1 parent65aa18e commitdb7c7b8Copy full SHA for db7c7b8

File tree

2 files changed

-2

lines changed

src/test/regress
- expected
  - identity.out
- sql
  - identity.sql

2 files changed

-2

lines changed

`‎src/test/regress/expected/identity.out`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ SELECT * FROM itest6;`
`303`	`303`	`102 \|`
`304`	`304`	`(3 rows)`
`305`	`305`
`306`		`-SELECT table_name, column_name, is_identity, identity_generation FROM information_schema.columns WHERE table_name = 'itest6';`
	`306`	`+SELECT table_name, column_name, is_identity, identity_generation FROM information_schema.columns WHERE table_name = 'itest6' ORDER BY 1, 2;`
`307`	`307`	`table_name \| column_name \| is_identity \| identity_generation`
`308`	`308`	`------------+-------------+-------------+---------------------`
`309`	`309`	`itest6 \| a \| YES \| BY DEFAULT`

`‎src/test/regress/sql/identity.sql`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ INSERT INTO itest6 DEFAULT VALUES;`
`183`	`183`	`INSERT INTO itest6 DEFAULTVALUES;`
`184`	`184`	`SELECT*FROM itest6;`
`185`	`185`
`186`		`-SELECT table_name, column_name, is_identity, identity_generationFROMinformation_schema.columnsWHERE table_name='itest6';`
	`186`	`+SELECT table_name, column_name, is_identity, identity_generationFROMinformation_schema.columnsWHERE table_name='itest6'ORDER BY1,2;`
`187`	`187`
`188`	`188`	`ALTERTABLE itest6 ALTER COLUMN bSET INCREMENT BY2;-- fail, not identity`
`189`	`189`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdb7c7b8

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/identity.out`

`‎src/test/regress/sql/identity.sql`

0 commit comments