Commitdb73b28

committed

Give nicer error message when connecting to a v10 server requiring SCRAM.

This is just to give the user a hint that they need to upgrade, if they tryto connect to a v10 server that uses SCRAM authentication, with an olderclient.Commit to all stable branches, but not master.Discussion:https://www.postgresql.org/message-id/bbf45d92-3896-eeb7-7399-2111d517261b@pivotal.io

1 parent6e86b44 commitdb73b28Copy full SHA for db73b28

File tree

+15

-0

lines changed

+15

-0

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -172,6 +172,8 @@ extern bool Db_user_namespace;`
`172`	`172`	`#defineAUTH_REQ_GSS7/* GSSAPI without wrap() */`
`173`	`173`	`#defineAUTH_REQ_GSS_CONT8/* Continue GSS exchanges */`
`174`	`174`	`#defineAUTH_REQ_SSPI9/* SSPI negotiate without wrap() */`
	`175`	`+#defineAUTH_REQ_SASL 10/* SASL authentication. Not supported before`
	`176`	`+ * libpq version 10. */`
`175`	`177`
`176`	`178`	`typedefuint32AuthRequest;`
`177`	`179`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -961,6 +961,19 @@ pg_fe_sendauth(AuthRequest areq, PGconn *conn)`
`961`	`961`	`returnSTATUS_ERROR;`
`962`	`962`	`break;`
`963`	`963`
	`964`	`+/*`
	`965`	`+ * SASL authentication was introduced in version 10. Older`
	`966`	`+ * versions recognize the request only to give a nicer error`
	`967`	`+ * message. We call it "SCRAM authentication" in the error, rather`
	`968`	`+ * than SASL, because SCRAM is more familiar to users, and it's`
	`969`	`+ * the only SASL authentication mechanism that has been`
	`970`	`+ * implemented as of this writing, anyway.`
	`971`	`+ */`
	`972`	`+caseAUTH_REQ_SASL:`
	`973`	`+printfPQExpBuffer(&conn->errorMessage,`
	`974`	`+libpq_gettext("SCRAM authentication requires libpq version 10 or above\n"));`
	`975`	`+returnSTATUS_ERROR;`
	`976`	`+`
`964`	`977`	`default:`
`965`	`978`	`printfPQExpBuffer(&conn->errorMessage,`
`966`	`979`	`libpq_gettext("authentication method %u not supported\n"),areq);`

Comments

(0)