Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitdb3d7e9

Browse files
committed
Remove useless picksplit-doesn't-support-secondary-split log spam.
This LOG message was put in over five years ago with the evidentexpectation that we'd make all GiST opclasses support secondary splitdirectly. However, no such thing ever happened, and indeed the number ofopclasses supporting it decreased to zero in 9.2. The reason is thatimproving on the default implementation isn't that easy --- theopclass-specific code that did exist, before 9.2, doesn't appear to havebeen any improvement over the default.Hence, remove the message altogether. There's certainly no point innagging users about this in released branches, but I doubt that we'llever implement complete opclass-specific support anyway.
1 parentdacc185 commitdb3d7e9

File tree

1 file changed

+5
-15
lines changed

1 file changed

+5
-15
lines changed

‎src/backend/access/gist/gistsplit.c

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -460,11 +460,6 @@ gistUserPicksplit(Relation r, GistEntryVector *entryvec, int attno, GistSplitVec
460460

461461
/* Do a generic split */
462462
genericPickSplit(giststate,entryvec,sv,attno);
463-
464-
/* Clean up if we're in a secondary split */
465-
if (sv->spl_ldatum_exists||sv->spl_rdatum_exists)
466-
supportSecondarySplit(r,giststate,attno,sv,
467-
v->spl_lattr[attno],v->spl_rattr[attno]);
468463
}
469464
else
470465
{
@@ -473,18 +468,13 @@ gistUserPicksplit(Relation r, GistEntryVector *entryvec, int attno, GistSplitVec
473468
sv->spl_left[sv->spl_nleft-1]= (OffsetNumber) (entryvec->n-1);
474469
if (sv->spl_right[sv->spl_nright-1]==InvalidOffsetNumber)
475470
sv->spl_right[sv->spl_nright-1]= (OffsetNumber) (entryvec->n-1);
476-
477-
/* Clean up if we're in a secondary split */
478-
if (sv->spl_ldatum_exists||sv->spl_rdatum_exists)
479-
{
480-
elog(DEBUG1,"picksplit method for column %d of index \"%s\" doesn't support secondary split",
481-
attno+1,RelationGetRelationName(r));
482-
483-
supportSecondarySplit(r,giststate,attno,sv,
484-
v->spl_lattr[attno],v->spl_rattr[attno]);
485-
}
486471
}
487472

473+
/* Clean up if PickSplit didn't take care of a secondary split */
474+
if (sv->spl_ldatum_exists||sv->spl_rdatum_exists)
475+
supportSecondarySplit(r,giststate,attno,sv,
476+
v->spl_lattr[attno],v->spl_rattr[attno]);
477+
488478
/* emit union datums computed by PickSplit back to v arrays */
489479
v->spl_lattr[attno]=sv->spl_ldatum;
490480
v->spl_rattr[attno]=sv->spl_rdatum;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp