Commitdb19924

committed

Remove NULL dereference from RenameRelationInternal().

Defect in last week's commitaac2c9b,per Coverity. Reaching this would need catalog corruption. Back-patchto v12, like that commit.

1 parent118dfd1 commitdb19924Copy full SHA for db19924

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3682,9 +3682,9 @@ RenameRelationInternal(Oid myrelid, const char *newrelname, bool is_internal, bo`
`3682`	`3682`	`relrelation = table_open(RelationRelationId, RowExclusiveLock);`
`3683`	`3683`
`3684`	`3684`	`reltup = SearchSysCacheLockedCopy1(RELOID, ObjectIdGetDatum(myrelid));`
`3685`		`-otid = reltup->t_self;`
`3686`	`3685`	`if (!HeapTupleIsValid(reltup))/* shouldn't happen */`
`3687`	`3686`	`elog(ERROR, "cache lookup failed for relation %u", myrelid);`
	`3687`	`+otid = reltup->t_self;`
`3688`	`3688`	`relform = (Form_pg_class) GETSTRUCT(reltup);`
`3689`	`3689`
`3690`	`3690`	`if (get_relname_relid(newrelname, namespaceId) != InvalidOid)`

Comments

(0)