Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitdb08e8c

Browse files
author
Amit Kapila
committed
Post-commit review fixes for slot synchronization.
Allow pg_sync_replication_slots() to error out during promotion of standby.This makes the behavior of the SQL function consistent with the slot syncworker. We also ensured that pg_sync_replication_slots() cannot beexecuted if sync_replication_slots is enabled and the slotsync worker isalready running to perform the synchronization of slots. Previously, itwould have succeeded in cases when the worker is idle and failed when itis performing sync which could confuse users.This patch fixes another issue in the slot sync worker whereSignalHandlerForShutdownRequest() needs to be registered *before* settingSlotSyncCtx->pid, otherwise, the slotsync worker could miss handlingSIGINT sent by the startup process(ShutDownSlotSync) if it is sent beforeworker could register SignalHandlerForShutdownRequest(). To be consistent,all signal handlers' registration is moved to a prior location before weset the worker's pid.Ensure that we clean up synced temp slots at the end ofpg_sync_replication_slots() to avoid such slots being left over afterpromotion.Ensure that ShutDownSlotSync() captures SlotSyncCtx->pid under spinlock toavoid accessing invalid value as it can be reset by concurrent slot syncexit due to an error.Author: Shveta MalikReviewed-by: Hou Zhijie, Bertrand Drouvot, Amit Kapila, Masahiko SawadaDiscussion:https://postgr.es/m/CAJpy0uBefXUS_TSz=oxmYKHdg-fhxUT0qfjASW3nmqnzVC3p6A@mail.gmail.com
1 parent0afa288 commitdb08e8c

File tree

6 files changed

+206
-98
lines changed

6 files changed

+206
-98
lines changed

‎doc/src/sgml/func.sgml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29349,6 +29349,10 @@ postgres=# SELECT '0/0'::pg_lsn + pd.segment_number * ps.setting::int + :offset
2934929349
standby server. Temporary synced slots, if any, cannot be used for
2935029350
logical decoding and must be dropped after promotion. See
2935129351
<xref linkend="logicaldecoding-replication-slots-synchronization"/> for details.
29352+
Note that this function cannot be executed if
29353+
<link linkend="guc-sync-replication-slots"><varname>
29354+
sync_replication_slots</varname></link> is enabled and the slotsync
29355+
worker is already running to perform the synchronization of slots.
2935229356
</para>
2935329357

2935429358
<caution>

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp