forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitdad50f6
committed
bufmgr: Acquire and clean victim buffer separately
Previously we held buffer locks for two buffer mapping partitions at the sametime to change the identity of buffers. Particularly for extending relationsneeding to hold the extension lock while acquiring a victim buffer ispainful.But it also creates a bottleneck for workloads that just involvereads.Now we instead first acquire a victim buffer and write it out, ifnecessary. Then we remove that buffer from the old partition with just the oldpartition's partition lock held and insert it into the new partition with justthat partition's lock held.By separating out the victim buffer acquisition, future commits will be ableto change relation extensions to scale better.On my workstation, a micro-benchmark exercising buffered reads strenuously andunder a lot of concurrency, sees a >2x improvement.Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>Reviewed-by: Melanie Plageman <melanieplageman@gmail.com>Discussion:https://postgr.es/m/20221029025420.eplyow6k7tgu6he3@awork3.anarazel.de1 parent65eb2d0 commitdad50f6
2 files changed
+369
-304
lines changed0 commit comments
Comments
(0)