forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitdacc185
committed
Remove vestigial secondary-split support in gist_box_picksplit().
Not only is this implementation of secondary-split not better than thedefault implementation in gistsplit.c, it's actually worse. The gistsplit.ccode at least looks to see if switching the left and right sides would makea better merge with the previously-split tuples, while this doesn't.In any case it's rather useless to support secondary split only in an edgecase. There used to be more complete support for it here (in chooseLR()),but that was removed in commit7f3bd86.It appears to me though that the chooseLR() code was really isomorphic tothe default implementation, since it was still based on choosing the cheaperway of adding two sub-split vectors that had been chosen without regard tothe primary split initially. I think an implementation of secondary splitthat could beat the default implementation would have to be pretty fullyintegrated into the split algorithm, not plastered on at the end.Back-patch to 9.2, but not further; previous branches have the chooseLR()code which I don't feel a great need to mess with. This is mainly so wejust have two behaviors and not three among the various branches (IOW, thispatch is cleanup for commit7f3bd86'sincomplete removal of secondary-split support).1 parent0fd0f36 commitdacc185
1 file changed
+0
-7
lines changedLines changed: 0 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
226 | | - | |
227 | | - | |
228 | 226 | | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | 227 | | |
233 | | - | |
234 | | - | |
235 | 228 | | |
236 | 229 | | |
237 | 230 | | |
| |||
0 commit comments
Comments
(0)