Commitda99df1

committed

Remove NULL dereference from RenameRelationInternal().

Defect in last week's commitaac2c9b,per Coverity. Reaching this would need catalog corruption. Back-patchto v12, like that commit.

1 parent4aad471 commitda99df1Copy full SHA for da99df1

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4143,9 +4143,9 @@ RenameRelationInternal(Oid myrelid, const char *newrelname, bool is_internal, bo`
`4143`	`4143`	`relrelation = table_open(RelationRelationId, RowExclusiveLock);`
`4144`	`4144`
`4145`	`4145`	`reltup = SearchSysCacheLockedCopy1(RELOID, ObjectIdGetDatum(myrelid));`
`4146`		`-otid = reltup->t_self;`
`4147`	`4146`	`if (!HeapTupleIsValid(reltup))/* shouldn't happen */`
`4148`	`4147`	`elog(ERROR, "cache lookup failed for relation %u", myrelid);`
	`4148`	`+otid = reltup->t_self;`
`4149`	`4149`	`relform = (Form_pg_class) GETSTRUCT(reltup);`
`4150`	`4150`
`4151`	`4151`	`if (get_relname_relid(newrelname, namespaceId) != InvalidOid)`

Comments

(0)