NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitda8954b

committed

Fix BuildIndexValueDescription for expressions

In804b6b6 we modifiedBuildIndexValueDescription to pay attention to which columns are visibleto the user, but unfortunatley that commit neglected to consider indexeswhich are built on expressions.Handle error-reporting of violations of constraint indexes based onexpressions by not returning any detail when the user does not havetable-level SELECT rights.Backpatch to 9.0, as the prior commit was.Pointed out by Tom.

1 parentdc9a506 commitda8954bCopy full SHA for da8954b

File tree

1 file changed

-4

lines changed

src/backend/access/index
- genam.c

1 file changed

-4

lines changed

`‎src/backend/access/index/genam.c`

Lines changed: 9 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -207,10 +207,15 @@ BuildIndexValueDescription(Relation indexRelation,`
`207`	`207`	`{`
`208`	`208`	`AttrNumberattnum=idxrec->indkey.values[keyno];`
`209`	`209`
`210`		`-aclresult=pg_attribute_aclcheck(indrelid,attnum,GetUserId(),`
`211`		`-ACL_SELECT);`
`212`		`-`
`213`		`-if (aclresult!=ACLCHECK_OK)`
	`210`	`+/*`
	`211`	`+ * Note that if attnum == InvalidAttrNumber, then this is an`
	`212`	`+ * index based on an expression and we return no detail rather`
	`213`	`+ * than try to figure out what column(s) the expression includes`
	`214`	`+ * and if the user has SELECT rights on them.`
	`215`	`+ */`
	`216`	`+if (attnum==InvalidAttrNumber\|\|`
	`217`	`+pg_attribute_aclcheck(indrelid,attnum,GetUserId(),`
	`218`	`+ACL_SELECT)!=ACLCHECK_OK)`
`214`	`219`	`{`
`215`	`220`	`/* No access, so clean up and return */`
`216`	`221`	`ReleaseSysCache(ht_idx);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitda8954b

File tree

1 file changed

1 file changed

`‎src/backend/access/index/genam.c`

0 commit comments