NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitda87dc0

committed

Add missing pointer dereference in pg_backend_memory_contexts view

32d3ed8 moved the logic for setting the context's name and ident intoa reusable function. I missed adding a pointer dereference aftercopying and pasting the code into that function. The ident parameter isa pointer to the ident variable in the calling function, so thedereference is required to correctly determine if the contents of thatvariable is NULL or not.In passing, adjust the if condition to include an == NULL to make itmore clear that it's not checking for == '\0'.Reported-by: Tom Lane, CoverityDiscussion:https://postgr.es/m/2256588.1722184287@sss.pgh.pa.us

1 parentc0ef123 commitda87dc0Copy full SHA for da87dc0

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- mcxtfuncs.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/mcxtfuncs.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ get_memory_context_name_and_ident(MemoryContext context, const char **const name`
`55`	`55`	`* To be consistent with logging output, we label dynahash contexts with`
`56`	`56`	`* just the hash table name as with MemoryContextStatsPrint().`
`57`	`57`	`*/`
`58`		`-if (ident&&strcmp(*name,"dynahash")==0)`
	`58`	`+if (ident==NULL&&strcmp(name,"dynahash")==0)`
`59`	`59`	`{`
`60`	`60`	`name=ident;`
`61`	`61`	`*ident=NULL;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitda87dc0

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/mcxtfuncs.c`

0 commit comments