NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitda42b9f

committed

Reimplement nullification of walsender timestamp

Make the value null only at pg_stat_activity-output time, as suggestedby Tom Lane, instead of messing with the internal state. This shouldappease buildfarm members with force_parallel_mode=regress, which arerunning parallel queries on logical replication walsenders.The fact that walsenders can run parallel queries should perhaps bestudied more carefully, but for the moment let's get rid of the redblots in buildfarm.Backpatch to pg10, like the previous commit.Discussion:https://postgr.es/m/30804.1578438763@sss.pgh.pa.us

1 parent0c046f8 commitda42b9fCopy full SHA for da42b9f

File tree

2 files changed

-8

lines changed

src/backend
- access/transam
  - xact.c
- utils/adt
  - pgstatfuncs.c

2 files changed

-8

lines changed

`‎src/backend/access/transam/xact.c`

Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -758,13 +758,6 @@ GetCurrentTransactionStopTimestamp(void)`
`758`	`758`	`void`
`759`	`759`	`SetCurrentStatementStartTimestamp(void)`
`760`	`760`	`{`
`761`		`-/*`
`762`		`- * Skip if on a walsender; this is not needed, and it confuses monitoring`
`763`		`- * if we publish non-NULL values.`
`764`		`- */`
`765`		`-if (am_walsender)`
`766`		`-return;`
`767`		`-`
`768`	`761`	`if (!IsParallelWorker())`
`769`	`762`	`stmtStartTimestamp=GetCurrentTimestamp();`
`770`	`763`	`else`

`‎src/backend/utils/adt/pgstatfuncs.c`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -732,7 +732,13 @@ pg_stat_get_activity(PG_FUNCTION_ARGS)`
`732`	`732`	`else`
`733`	`733`	`nulls[7]= true;`
`734`	`734`
`735`		`-if (beentry->st_xact_start_timestamp!=0)`
	`735`	`+/*`
	`736`	`+ * Don't expose transaction time for walsenders; it confuses`
	`737`	`+ * monitoring, particularly because we don't keep the time up-to-`
	`738`	`+ * date.`
	`739`	`+ */`
	`740`	`+if (beentry->st_xact_start_timestamp!=0&&`
	`741`	`+beentry->st_backendType!=B_WAL_SENDER)`
`736`	`742`	`values[8]=TimestampTzGetDatum(beentry->st_xact_start_timestamp);`
`737`	`743`	`else`
`738`	`744`	`nulls[8]= true;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitda42b9f

File tree

2 files changed

2 files changed

`‎src/backend/access/transam/xact.c`

`‎src/backend/utils/adt/pgstatfuncs.c`

0 commit comments