NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitda42121

Etsuro Fujita

committed

Update comment about set_join_pathlist_hook().

The comment introduced by commite7cb7ee was a bit too terse, whichcould lead to extensions doing different things within the hook functionthan we intend to allow. Extend the comment to explain what they can dowithin the hook function.Back-patch to all supported branches.In passing, I rephrased a nearby comment that I recently added to theback branches.Reviewed by David Rowley and Andrei Lepikhov.Discussion:https://postgr.es/m/CAPmGK15SBPA1nr3Aqsdm%2BYyS-ay0Ayo2BRYQ8_A2To9eLqwopQ%40mail.gmail.com

1 parentbd7a18e commitda42121Copy full SHA for da42121

File tree

1 file changed

-2

lines changed

src/backend/optimizer/path
- joinpath.c

1 file changed

-2

lines changed

`‎src/backend/optimizer/path/joinpath.c‎`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,8 @@ add_paths_to_joinrel(PlannerInfo *root,`
`323`	`323`	`/*`
`324`	`324`	`* createplan.c does not currently support handling of pseudoconstant`
`325`	`325`	`* clauses assigned to joins pushed down by extensions; check if the`
`326`		`- * restrictlist has such clauses, and if so, disallow pushing down joins.`
	`326`	`+ * restrictlist has such clauses, and if not, allow them to consider`
	`327`	`+ * pushing down joins.`
`327`	`328`	`*/`
`328`	`329`	`if ((joinrel->fdwroutine&&`
`329`	`330`	`joinrel->fdwroutine->GetForeignJoinPaths)\|\|`
`@@ -344,7 +345,10 @@ add_paths_to_joinrel(PlannerInfo *root,`
`344`	`345`	`jointype,&extra);`
`345`	`346`
`346`	`347`	`/*`
`347`		`- * 6. Finally, give extensions a chance to manipulate the path list.`
	`348`	`+ * 6. Finally, give extensions a chance to manipulate the path list. They`
	`349`	`+ * could add new paths (such as CustomPaths) by calling add_path(), or`
	`350`	`+ * add_partial_path() if parallel aware. They could also delete or modify`
	`351`	`+ * paths added by the core code.`
`348`	`352`	`*/`
`349`	`353`	`if (set_join_pathlist_hook&&`
`350`	`354`	`consider_join_pushdown)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitda42121

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/joinpath.c‎`

0 commit comments