Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitda13d90

Browse files
committed
Make constraint rename issue relcache invalidation on target relation
When a constraint gets renamed, it may have associated with it a targetrelation (for example domain constraints don't have one). Notinvalidating the target relation cache when issuing the renaming canresult in issues with subsequent commands that refer to the oldconstraint name using the relation cache, causing various failures. Onepattern spotted was using CREATE TABLE LIKE after a constraintrenaming.Reported-by: Stuart <sfbarbee@gmail.com>Author: Amit LangoteReviewed-by: Michael PaquierDiscussion:https://postgr.es/m/2047094.V130LYfLq4@station53.ousa.org
1 parentf429011 commitda13d90

File tree

3 files changed

+43
-0
lines changed

3 files changed

+43
-0
lines changed

‎src/backend/commands/tablecmds.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2827,8 +2827,15 @@ rename_constraint_internal(Oid myrelid,
28272827
ReleaseSysCache(tuple);
28282828

28292829
if (targetrelation)
2830+
{
28302831
relation_close(targetrelation,NoLock);/* close rel but keep lock */
28312832

2833+
/*
2834+
* Invalidate relcache so as others can see the new constraint name.
2835+
*/
2836+
CacheInvalidateRelcache(targetrelation);
2837+
}
2838+
28322839
returnaddress;
28332840
}
28342841

‎src/test/regress/expected/alter_table.out

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,28 @@ ALTER TABLE IF EXISTS constraint_not_exist RENAME CONSTRAINT con3 TO con3foo; --
342342
NOTICE: relation "constraint_not_exist" does not exist, skipping
343343
ALTER TABLE IF EXISTS constraint_rename_test ADD CONSTRAINT con4 UNIQUE (a);
344344
NOTICE: relation "constraint_rename_test" does not exist, skipping
345+
-- renaming constraints with cache reset of target relation
346+
CREATE TABLE constraint_rename_cache (a int,
347+
CONSTRAINT chk_a CHECK (a > 0),
348+
PRIMARY KEY (a));
349+
ALTER TABLE constraint_rename_cache
350+
RENAME CONSTRAINT chk_a TO chk_a_new;
351+
ALTER TABLE constraint_rename_cache
352+
RENAME CONSTRAINT constraint_rename_cache_pkey TO chk_a_gt_zero;
353+
CREATE TABLE like_constraint_rename_cache
354+
(LIKE constraint_rename_cache INCLUDING ALL);
355+
\d like_constraint_rename_cache
356+
Table "public.like_constraint_rename_cache"
357+
Column | Type | Collation | Nullable | Default
358+
--------+---------+-----------+----------+---------
359+
a | integer | | not null |
360+
Indexes:
361+
"like_constraint_rename_cache_pkey" PRIMARY KEY, btree (a)
362+
Check constraints:
363+
"chk_a_new" CHECK (a > 0)
364+
365+
DROP TABLE constraint_rename_cache;
366+
DROP TABLE like_constraint_rename_cache;
345367
-- FOREIGN KEY CONSTRAINT adding TEST
346368
CREATE TABLE tmp2 (a int primary key);
347369
CREATE TABLE tmp3 (a int, b int);

‎src/test/regress/sql/alter_table.sql

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,20 @@ DROP TABLE constraint_rename_test;
251251
ALTERTABLE IF EXISTS constraint_not_exist RENAMECONSTRAINT con3 TO con3foo;-- ok
252252
ALTERTABLE IF EXISTS constraint_rename_test ADDCONSTRAINT con4 UNIQUE (a);
253253

254+
-- renaming constraints with cache reset of target relation
255+
CREATETABLEconstraint_rename_cache (aint,
256+
CONSTRAINT chk_aCHECK (a>0),
257+
PRIMARY KEY (a));
258+
ALTERTABLE constraint_rename_cache
259+
RENAMECONSTRAINT chk_a TO chk_a_new;
260+
ALTERTABLE constraint_rename_cache
261+
RENAMECONSTRAINT constraint_rename_cache_pkey TO chk_a_gt_zero;
262+
CREATETABLElike_constraint_rename_cache
263+
(LIKE constraint_rename_cache INCLUDING ALL);
264+
\d like_constraint_rename_cache
265+
DROPTABLE constraint_rename_cache;
266+
DROPTABLE like_constraint_rename_cache;
267+
254268
-- FOREIGN KEY CONSTRAINT adding TEST
255269

256270
CREATETABLEtmp2 (aintprimary key);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp