NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd9c5b9a

committed

Fix bug in brin_minmax_multi_union

When calling sort_expanded_ranges() we need to remember the returnvalue, because the function sorts and also deduplicates the ranges. Sothe number of ranges may decrease. brin_minmax_multi_union failed to dothat, which resulted in crashes due to bogus ranges (equal minval/maxvalbut not marked as compacted).Reported-by: Jaime CasanovaDiscussion:https://postgr.es/m/20210404052550.GA4376%40ahch-to

1 parent4908684 commitd9c5b9aCopy full SHA for d9c5b9a

File tree

1 file changed

-1

lines changed

src/backend/access/brin
- brin_minmax_multi.c

1 file changed

-1

lines changed

`‎src/backend/access/brin/brin_minmax_multi.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2794,7 +2794,7 @@ brin_minmax_multi_union(PG_FUNCTION_ARGS)`
`2794`	`2794`	`BTLessStrategyNumber);`
`2795`	`2795`
`2796`	`2796`	`/* sort the expanded ranges */`
`2797`		`-sort_expanded_ranges(cmpFn,colloid,eranges,neranges);`
	`2797`	`+neranges=sort_expanded_ranges(cmpFn,colloid,eranges,neranges);`
`2798`	`2798`
`2799`	`2799`	`/*`
`2800`	`2800`	`* We've loaded two different lists of expanded ranges, so some of them`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd9c5b9a

File tree

1 file changed

1 file changed

`‎src/backend/access/brin/brin_minmax_multi.c‎`

0 commit comments