NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd8453cc

committed

Revert "Silence compiler warning"

This reverts commit9dc1225.As committed, statement sampling used the existing duration threshold(log_min_duration_statement) when decide which statements to sample.The issue is that even the longest statements are subject to sampling,and so may not end up logged. An improvement was proposed, introducinga second duration threshold, but it would not be backwards compatible.So we've decided to revert this feature - the separate threshold shouldbe part of the feature itself.Discussion:https://postgr.es/m/CAFj8pRDS8tQ3Wviw9%3DAvODyUciPSrGeMhJi_WPE%2BEB8%2B4gLL-Q%40mail.gmail.com

1 parentdf521ab commitd8453ccCopy full SHA for d8453cc

File tree

1 file changed

-7

lines changed

src/backend/tcop
- postgres.c

1 file changed

-7

lines changed

`‎src/backend/tcop/postgres.c`

Lines changed: 6 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -2236,14 +2236,13 @@ check_log_duration(char *msec_str, bool was_logged)`
`2236`	`2236`
`2237`	`2237`	`/*`
`2238`	`2238`	`* Do not log if log_statement_sample_rate = 0. Log a sample if`
`2239`		`- * log_statement_sample_rate <= 1 and avoid unnecessary random() call`
`2240`		`- * if log_statement_sample_rate = 1. But don't compute any of this`
`2241`		`- * unless needed.`
	`2239`	`+ * log_statement_sample_rate <= 1 and avoid unecessary random() call`
	`2240`	`+ * if log_statement_sample_rate = 1.`
`2242`	`2241`	`*/`
`2243`		`-in_sample=exceeded&&`
`2244`		`-log_statement_sample_rate!=0&&`
`2245`		`-(log_statement_sample_rate==1\|\|`
`2246`		`-random() <=log_statement_sample_rate*MAX_RANDOM_VALUE);`
	`2242`	`+if (exceeded)`
	`2243`	`+in_sample=log_statement_sample_rate!=0&&`
	`2244`	`+(log_statement_sample_rate==1\|\|`
	`2245`	`+random() <=log_statement_sample_rate*MAX_RANDOM_VALUE);`
`2247`	`2246`
`2248`	`2247`	`if ((exceeded&&in_sample)\|\|log_duration\|\|xact_is_sampled)`
`2249`	`2248`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd8453cc

File tree

1 file changed

1 file changed

`‎src/backend/tcop/postgres.c`

0 commit comments