Commitd81cd70

committed

Standardize output buffer size and display format for strftime;

followup to complaint from Korean User's Group.

1 parent682a6bd commitd81cd70Copy full SHA for d81cd70

File tree

+14

-15

lines changed

+14

-15

lines changed

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,21 +5,20 @@`
`5`	`5`	`*/`
`6`	`6`
`7`	`7`	`#include"pg_autovacuum.h"`
`8`		`-#defineTIMEBUFF 256`
	`8`	`+`
`9`	`9`	`FILE*LOGOUTPUT;`
`10`		`-chartimebuffer[TIMEBUFF];`
`11`	`10`	`charlogbuffer[4096];`
`12`	`11`
`13`	`12`	`void`
`14`	`13`	`log_entry(constchar*logentry)`
`15`	`14`	`{`
`16`	`15`	`time_tcurtime;`
`17`	`16`	`structtm*loctime;`
	`17`	`+chartimebuffer[128];`
`18`	`18`
`19`	`19`	`curtime=time(NULL);`
`20`	`20`	`loctime=localtime(&curtime);`
`21`		`-strftime(timebuffer,TIMEBUFF,"%Y-%m-%d %r",loctime);/* cbb - %F is not`
`22`		`- * always available */`
	`21`	`+strftime(timebuffer,sizeof(timebuffer),"%Y-%m-%d %H:%M:%S %Z",loctime);`
`23`	`22`	`fprintf(LOGOUTPUT,"[%s] %s\n",timebuffer,logentry);`
`24`	`23`	`}`
`25`	`24`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`*`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/nabstime.c,v 1.118 2003/11/29 19:51:58 pgsql Exp $`
	`13`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/nabstime.c,v 1.119 2004/03/22 15:34:22 tgl Exp $`
`14`	`14`	`*`
`15`	`15`	`*-------------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -1724,8 +1724,8 @@ timeofday(PG_FUNCTION_ARGS)`
`1724`	`1724`	`{`
`1725`	`1725`	`structtimevaltp;`
`1726`	`1726`	`structtimezonetpz;`
`1727`		`-chartempl[100];`
`1728`		`-charbuf[100];`
	`1727`	`+chartempl[128];`
	`1728`	`+charbuf[128];`
`1729`	`1729`	`text*result;`
`1730`	`1730`	`intlen;`
`1731`	`1731`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`*`
`38`	`38`	`*`
`39`	`39`	`* IDENTIFICATION`
`40`		`- * $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.130 2004/03/21 22:29:11 tgl Exp $`
	`40`	`+ * $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.131 2004/03/22 15:34:22 tgl Exp $`
`41`	`41`	`*`
`42`	`42`	`*-------------------------------------------------------------------------`
`43`	`43`	`*/`
`@@ -1187,9 +1187,9 @@ log_line_prefix(StringInfo buf)`
`1187`	`1187`	`case't':`
`1188`	`1188`	`{`
`1189`	`1189`	`time_tstamp_time=time(NULL);`
`1190`		`-charstrfbuf[32];`
	`1190`	`+charstrfbuf[128];`
`1191`	`1191`
`1192`		`-strftime(strfbuf,sizeof(strfbuf),"%Y-%m-%d %H:%M:%S",`
	`1192`	`+strftime(strfbuf,sizeof(strfbuf),"%Y-%m-%d %H:%M:%S %Z",`
`1193`	`1193`	`localtime(&stamp_time));`
`1194`	`1194`	`appendStringInfoString(buf,strfbuf);`
`1195`	`1195`	`}`
`@@ -1198,9 +1198,9 @@ log_line_prefix(StringInfo buf)`
`1198`	`1198`	`if (MyProcPort)`
`1199`	`1199`	`{`
`1200`	`1200`	`time_tstamp_time=MyProcPort->session_start.tv_sec;`
`1201`		`-charstrfbuf[32];`
	`1201`	`+charstrfbuf[128];`
`1202`	`1202`
`1203`		`-strftime(strfbuf,sizeof(strfbuf),"%Y-%m-%d %H:%M:%S",`
	`1203`	`+strftime(strfbuf,sizeof(strfbuf),"%Y-%m-%d %H:%M:%S %Z",`
`1204`	`1204`	`localtime(&stamp_time));`
`1205`	`1205`	`appendStringInfoString(buf,strfbuf);`
`1206`	`1206`	`}`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`* copyright (c) Oliver Elphick <olly@lfix.co.uk>, 2001;`
`7`	`7`	`* licence: BSD`
`8`	`8`	`*`
`9`		`- * $PostgreSQL: pgsql/src/bin/pg_controldata/pg_controldata.c,v 1.13 2004/02/11 22:55:25 tgl Exp $`
	`9`	`+ * $PostgreSQL: pgsql/src/bin/pg_controldata/pg_controldata.c,v 1.14 2004/03/22 15:34:22 tgl Exp $`
`10`	`10`	`*/`
`11`	`11`	`#include"postgres.h"`
`12`	`12`
`@@ -71,8 +71,8 @@ main(int argc, char *argv[])`
`71`	`71`	`charControlFilePath[MAXPGPATH];`
`72`	`72`	`char*DataDir;`
`73`	`73`	`crc64crc;`
`74`		`-charpgctime_str[32];`
`75`		`-charckpttime_str[32];`
	`74`	`+charpgctime_str[128];`
	`75`	`+charckpttime_str[128];`
`76`	`76`	`charsysident_str[32];`
`77`	`77`	`char*strftime_fmt="%c";`
`78`	`78`	`char*progname;`

Comments

(0)