forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitd811ce6
committed
pgstat: Fix transactional stats dropping for indexes
Because index creation does not go through heap_create_with_catalog() wedidn't call pgstat_create_relation(), leading to index stats of a newlycreated realtion not getting dropped during rollback. To fix, move thepgstat_create_relation() to heap_create(), which indexes do use.Similarly, because dropping an index does not go throughheap_drop_with_catalog(), we didn't drop index stats when the transactiondropping an index committed. Here there's no convenient common path forindexes and relations, so index_drop() now calls pgstat_drop_relation().Add tests for transactional index stats handling.Author: "Drouvot, Bertrand" <bdrouvot@amazon.com>Reviewed-by: Andres Freund <andres@anarazel.de>Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>Discussion:https://postgr.es/m/51bbf286-2b4a-8998-bd12-eaae4b765d99@amazon.comBackpatch: 15-, like8b1dccd, which introduced the bug1 parent0032a54 commitd811ce6
4 files changed
+161
-7
lines changedLines changed: 3 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
403 | 403 |
| |
404 | 404 |
| |
405 | 405 |
| |
| 406 | + | |
| 407 | + | |
| 408 | + | |
406 | 409 |
| |
407 | 410 |
| |
408 | 411 |
| |
| |||
1477 | 1480 |
| |
1478 | 1481 |
| |
1479 | 1482 |
| |
1480 |
| - | |
1481 |
| - | |
1482 |
| - | |
1483 | 1483 |
| |
1484 | 1484 |
| |
1485 | 1485 |
| |
|
Lines changed: 3 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2325 | 2325 |
| |
2326 | 2326 |
| |
2327 | 2327 |
| |
| 2328 | + | |
| 2329 | + | |
| 2330 | + | |
2328 | 2331 |
| |
2329 | 2332 |
| |
2330 | 2333 |
| |
|
Lines changed: 107 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
18 | 18 |
| |
19 | 19 |
| |
20 | 20 |
| |
| 21 | + | |
| 22 | + | |
21 | 23 |
| |
22 | 24 |
| |
23 | 25 |
| |
| |||
777 | 779 |
| |
778 | 780 |
| |
779 | 781 |
| |
780 |
| - | |
| 782 | + | |
781 | 783 |
| |
782 | 784 |
| |
783 | 785 |
| |
784 | 786 |
| |
785 | 787 |
| |
786 |
| - | |
| 788 | + | |
787 | 789 |
| |
788 | 790 |
| |
789 | 791 |
| |
790 | 792 |
| |
791 | 793 |
| |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
792 | 897 |
| |
793 | 898 |
| |
794 | 899 |
| |
|
Lines changed: 48 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
16 | 16 |
| |
17 | 17 |
| |
18 | 18 |
| |
| 19 | + | |
| 20 | + | |
| 21 | + | |
19 | 22 |
| |
20 | 23 |
| |
21 | 24 |
| |
| |||
388 | 391 |
| |
389 | 392 |
| |
390 | 393 |
| |
391 |
| - | |
392 |
| - | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
393 | 437 |
| |
| 438 | + | |
| 439 | + | |
394 | 440 |
| |
395 | 441 |
| |
396 | 442 |
| |
|
0 commit comments
Comments
(0)