Commitd802ff0

committed

Fix backstop in gin test if injection point is not reached

Per Tom Lane's observation that the test got stuck in infinite loop ifthe injection_points module was not loaded. It was supposed to give upafter 10000 iterations, but the backstop was broken.Discussion:https://www.postgresql.org/message-id/2498595.1710511222%40sss.pgh.pa.us

1 parent85f65d7 commitd802ff0Copy full SHA for d802ff0

File tree

-4

lines changed

-4

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,7 @@ declare`
`45`	`45`	`i integer;`
`46`	`46`	`begin`
`47`	`47`	`-- Insert arrays with 'step' elements each, until an error occurs.`
	`48`	`+ i := 0;`
`48`	`49`	`loop`
`49`	`50`	`begin`
`50`	`51`	`select insert_n(next_i, step) into next_i;`
`@@ -53,12 +54,12 @@ begin`
`53`	`54`	`exit;`
`54`	`55`	`end;`
`55`	`56`
`56`		`- -- The caller is expected to set an injection point thateventuall`
	`57`	`+ -- The caller is expected to set an injection point thateventually`
`57`	`58`	`-- causes an error. But bail out if still no error after 10000`
`58`	`59`	`-- attempts, so that we don't get stuck in an infinite loop.`
`59`	`60`	`i := i + 1;`
`60`	`61`	`if i = 10000 then`
`61`		`- raise 'no error on inserts after';`
	`62`	`+ raise 'no error on inserts after% iterations', i;`
`62`	`63`	`end if;`
`63`	`64`	`end loop;`
`64`	`65`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,7 @@ declare`
`48`	`48`	`iinteger;`
`49`	`49`	`begin`
`50`	`50`	`-- Insert arrays with 'step' elements each, until an error occurs.`
	`51`	`+ i :=0;`
`51`	`52`	`loop`
`52`	`53`	`begin`
`53`	`54`	`select insert_n(next_i, step) into next_i;`
`@@ -56,12 +57,12 @@ begin`
`56`	`57`	`exit;`
`57`	`58`	`end;`
`58`	`59`
`59`		`--- The caller is expected to set an injection point thateventuall`
	`60`	`+-- The caller is expected to set an injection point thateventually`
`60`	`61`	`-- causes an error. But bail out if still no error after 10000`
`61`	`62`	`-- attempts, so that we don't get stuck in an infinite loop.`
`62`	`63`	`i := i+1;`
`63`	`64`	`if i=10000 then`
`64`		`- raise'no error on inserts after';`
	`65`	`+ raise'no error on inserts after% iterations', i;`
`65`	`66`	`end if;`
`66`	`67`	`end loop;`
`67`	`68`

Comments

(0)