NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd7fa90f

committed

doc: wire protocol data type for history file content is bytea

Document that though the history file content is marked as bytea, it isthe same a text, and neither is btyea-escaped or encoding converted.Reported-by: Brar PieningDiscussion:https://postgr.es/m/6a1b9cd9-17e3-df67-be55-86102af6bdf5@gmx.deBackpatch-through: 13 - 9.5 (not master)

1 parent7f69ed4 commitd7fa90fCopy full SHA for d7fa90f

File tree

2 files changed

-1

lines changed

doc/src/sgml
- protocol.sgml
src/backend/replication
- walsender.c

2 files changed

-1

lines changed

`‎doc/src/sgml/protocol.sgml`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1858,7 +1858,10 @@ The commands accepted in replication mode are:`
`1858`	`1858`	`<para>`
`1859`	`1859`	`Requests the server to send over the timeline history file for timeline`
`1860`	`1860`	`<replaceable class="parameter">tli</replaceable>. Server replies with a`
`1861`		`- result set of a single row, containing two fields:`
	`1861`	`+ result set of a single row, containing two fields. While the`
	`1862`	`+ fields are labeled as <type>text</type> and <type>bytea</type>,`
	`1863`	`+ they effectively return raw bytes, with no escaping or encoding`
	`1864`	`+ conversion:`
`1862`	`1865`	`</para>`
`1863`	`1866`
`1864`	`1867`	`<para>`

`‎src/backend/replication/walsender.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -466,6 +466,10 @@ SendTimeLineHistory(TimeLineHistoryCmd *cmd)`
`466`	`466`	`pq_sendstring(&buf,"content");/* col name */`
`467`	`467`	`pq_sendint32(&buf,0);/* table oid */`
`468`	`468`	`pq_sendint16(&buf,0);/* attnum */`
	`469`	`+/*`
	`470`	`+ * While this is labeled as BYTEAOID, it is the same output format`
	`471`	`+ * as TEXTOID above.`
	`472`	`+ */`
`469`	`473`	`pq_sendint32(&buf,BYTEAOID);/* type oid */`
`470`	`474`	`pq_sendint16(&buf,-1);/* typlen */`
`471`	`475`	`pq_sendint32(&buf,0);/* typmod */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd7fa90f

File tree

2 files changed

2 files changed

`‎doc/src/sgml/protocol.sgml`

`‎src/backend/replication/walsender.c`

0 commit comments