NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd7cbeaf

committed

Remove pgstat_flush_wal()

All the processes that generate WAL should call pgstat_report_wal() toreport all their statistics related to WAL, and this is already whathappens in the tree. Keeping pgstat_report_wal() is confusing while theother routine is encouraged.This routine is not required sincefc415ed, where it was lastlyused in pgstat_report_stat() before an equivalent callback existed.Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>Discussion:https://postgr.es/m/Z71oPkJJICrRB5Ws@paquier.xyz

1 parente117cfb commitd7cbeafCopy full SHA for d7cbeaf

File tree

2 files changed

-12

lines changed

src
- backend/utils/activity
  - pgstat_wal.c
- include/utils
  - pgstat_internal.h

2 files changed

-12

lines changed

`‎src/backend/utils/activity/pgstat_wal.c‎`

Lines changed: 1 addition & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ pgstat_report_wal(bool force)`
`51`	`51`	`nowait= !force;`
`52`	`52`
`53`	`53`	`/* flush wal stats */`
`54`		`-pgstat_flush_wal(nowait);`
	`54`	`+(void)pgstat_wal_flush_cb(nowait);`
`55`	`55`
`56`	`56`	`/* flush IO stats */`
`57`	`57`	`pgstat_flush_io(nowait);`
`@@ -69,15 +69,6 @@ pgstat_fetch_stat_wal(void)`
`69`	`69`	`return&pgStatLocal.snapshot.wal;`
`70`	`70`	`}`
`71`	`71`
`72`		`-/*`
`73`		`- * Simple wrapper of pgstat_wal_flush_cb()`
`74`		`- */`
`75`		`-void`
`76`		`-pgstat_flush_wal(boolnowait)`
`77`		`-{`
`78`		`-(void)pgstat_wal_flush_cb(nowait);`
`79`		`-}`
`80`		`-`
`81`	`72`	`/*`
`82`	`73`	`* Calculate how much WAL usage counters have increased by subtracting the`
`83`	`74`	`* previous counters from the current ones.`

`‎src/include/utils/pgstat_internal.h‎`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -748,8 +748,6 @@ extern void pgstat_slru_snapshot_cb(void);`
`748`	`748`	`* Functions in pgstat_wal.c`
`749`	`749`	`*/`
`750`	`750`
`751`		`-externvoidpgstat_flush_wal(boolnowait);`
`752`		`-`
`753`	`751`	`externvoidpgstat_wal_init_backend_cb(void);`
`754`	`752`	`externboolpgstat_wal_have_pending_cb(void);`
`755`	`753`	`externboolpgstat_wal_flush_cb(boolnowait);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd7cbeaf

File tree

2 files changed

2 files changed

`‎src/backend/utils/activity/pgstat_wal.c‎`

`‎src/include/utils/pgstat_internal.h‎`

0 commit comments