NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd7bf9ad

committed

Fix comment on when HOT update is possible.

The conditions listed in this comment have changed several times, and atsome point the thing that the "if so" referred to was negated.The text was OK up to 9.6. It was differently wrong in v10, v11 andmaster, so fix in all those versions.

1 parent0569f04 commitd7bf9adCopy full SHA for d7bf9ad

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4160,7 +4160,7 @@ heap_update(Relation relation, ItemPointer otid, HeapTuple newtup,`
`4160`	`4160`	`* Since the new tuple is going into the same page, we might be able`
`4161`	`4161`	`* to do a HOT update. Check if any of the index columns have been`
`4162`	`4162`	`* changed. If the page was already full, we may have skipped checking`
`4163`		`- * for index columns. If so, HOT update is possible.`
	`4163`	`+ * for index columns, and also can't do a HOT update.`
`4164`	`4164`	`*/`
`4165`	`4165`	`if (hot_attrs_checked&& !bms_overlap(modified_attrs,hot_attrs))`
`4166`	`4166`	`use_hot_update= true;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd7bf9ad

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c`

0 commit comments